Skip to content

Dock desktop terminal below the right panel#466

Merged
BunsDev merged 1 commit intomainfrom
okcode/limit-panels-terminal-below
Apr 18, 2026
Merged

Dock desktop terminal below the right panel#466
BunsDev merged 1 commit intomainfrom
okcode/limit-panels-terminal-below

Conversation

@BunsDev
Copy link
Copy Markdown
Member

@BunsDev BunsDev commented Apr 18, 2026

Summary

  • Dock the existing terminal drawer into a desktop right-panel host when the panel is open.
  • Keep the current inline terminal rendering as a fallback when the dock host is unavailable or on mobile.
  • Extract the desktop shell placement rules into a small pure helper with unit tests.
  • Add a route-owned terminal dock host beneath the right panel in the desktop layout.

Testing

  • Added apps/web/src/desktopShellLayout.test.ts covering shell counting and terminal placement rules.
  • Not run: bun fmt
  • Not run: bun lint
  • Not run: bun typecheck

- Add a pure helper for counted desktop shells and terminal dock placement
- Portal the existing terminal drawer into a right-panel dock host with inline fallback
- Cover the layout rules with Vitest and document the desktop shell design
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
okcode-marketing Ready Ready Preview Apr 18, 2026 7:39pm
v0-compute-the-platform-to-build Ready Ready Preview, Open in v0 Apr 18, 2026 7:39pm

@github-actions github-actions bot added size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 18, 2026
@BunsDev BunsDev merged commit 9b882d6 into main Apr 18, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant