fixed keyword replacement for single doc bubbles #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the occurence of empty bubbles in cases containing only one paper which is additionally missing keywords. Previously, no replacement keywords could be generated as only documents with missing keywords were considered.
Now all documents of a map will be considered for replacement keyword generation (change in L79) while only the documents with missing keywords will be replaced (change in L96).
The effect can be seen in the map for "financial distress" on PubMed with the search range 5 Feb 2019 - 12 Feb 2019.
Additionally, minimal differences may occur in maps with documents which lack keywords, as can be seen in the BASE map of digital education. In general, this may be an improvement, since missing keywords will be replaced with the whole map in mind, leading to them being more representative.