Skip to content

Conversation

@Konstiman
Copy link
Contributor

This PR introduces the 2nd part of the knowledge map component refactoring.

It follows up on the PR #512

The flag MODERN_FRONTEND doesn't do anything here, all the flagged legacy code has been removed.

Features:

  • removed all the knowledge map legacy code
  • bugfixes
  • code cleanup

Jan Konstant added 30 commits December 1, 2020 15:41
commented out most of the legacy code
components prototypes
force layout first working version
zoom in/out (no animation yet)
resize in zoom
bubbles order on hover/zoom
selecting, hovering, deselecting
the resize on hover is just prototype
with known bug: zooming to a different bubble
prepared middleware for queued actions
any action that changes the map state is queued during the animation

bubble and paper order moved to store

known bug: hovered paper after zoom in
text truncating doesn't work again
hyphenation + shave + highlighting
commented out more legacy code
middlewares in intermediate
bubble titles set with dangerouslySetInnerHTML
@chreman chreman merged commit bd4cc7a into master Feb 5, 2021
@Konstiman Konstiman deleted the refactoring-map-final branch March 9, 2021 09:48
chreman added a commit to chreman/Headstart that referenced this pull request Oct 13, 2021
…toring-map-final

Refactoring (Map): final phase

Former-commit-id: bd4cc7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants