Adding Versionless Support #1827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherylking
reviewed
Sep 5, 2024
Member
cherylking
left a comment
cherylking
left a comment
There was a problem hiding this comment.
You should update the maven.yaml to reference your ci.common PR branch so the builds can pass and the tests run.
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/InstallFeatureSupport.java
Outdated
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Outdated
Show resolved
Hide resolved
cherylking
reviewed
Sep 8, 2024
liberty-maven-plugin/src/it/server-config-props-it/cleanTest.bsh
Outdated
Show resolved
Hide resolved
cherylking
reviewed
Sep 8, 2024
...config-props-it/src/test/java/net/wasdev/wlp/test/servlet/it/ServerConfigPropertiesTest.java
Show resolved
Hide resolved
cherylking
reviewed
Sep 8, 2024
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Show resolved
Hide resolved
cherylking
approved these changes
Sep 12, 2024
Removed temp change pointing to common branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm now passing
<platform>elements along with<feature>elements while calculating which parameters to pass the Install Map