create CDI introspector #33740

benjamin-confino · 2026-01-05T10:49:15Z

I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

Resolves #33739

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/liberty/CDIIntrospector.java

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/impl/weld/BeanDeploymentArchiveImpl.java

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/liberty/CDIIntrospector.java

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/impl/weld/BeanDeploymentArchiveImpl.java

Azquelt · 2026-01-05T13:29:30Z

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/impl/weld/BeanDeploymentArchiveImpl.java

+            if (beansXml != null)
+                out.println("++++ beansXml:" + beansXml + "++++");


To check: does beansXml have a useful toString?

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/impl/weld/BeanDeploymentArchiveImpl.java

Azquelt · 2026-01-05T14:35:01Z

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/liberty/CDIIntrospector.java

+@Component(immediate = true, configurationPolicy = ConfigurationPolicy.IGNORE, property = {
+                                                                                            Constants.SERVICE_VENDOR + "=" + "IBM" })


Does this need to be immediate?

We don't need to add the service.vendor property any more.

benjamin-confino · 2026-01-05T15:39:24Z

!build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-01-05T15:48:16Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

7 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2026-01-05T15:48:25Z

The following files contain disallowed content:

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/impl/weld/BeanDeploymentArchiveImpl.java

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/impl/weld/BeanDeploymentArchiveImpl.java

Azquelt · 2026-01-05T16:08:06Z

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/impl/weld/BeanDeploymentArchiveImpl.java

+        String url = "beansXML URL: " + beansXml.getUrl();
+        out.println("beansXML URL: " + url);


You don't want "beansXML URL: " twice here

Azquelt

Looks great, thanks, this should be really helpful when we're trying to work out why CDI has or hasn't found what we expected it to.

benjamin-confino · 2026-01-05T16:17:45Z

!build (view Open Liberty Personal Build - ⚠️ completed with warnings.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-01-05T16:25:13Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

7 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2026-01-05T16:26:18Z

The following files contain disallowed content:

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/impl/weld/BeanDeploymentArchiveImpl.java

benjamin-confino · 2026-01-05T21:45:06Z

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2026-01-05T21:54:10Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

7 product code files were changed.
Please describe in a separate comment how you tested your changes.

Azquelt

Please do squash the commits before merging.

Cleanup some comments

benjamin-confino · 2026-01-08T10:05:39Z

#libby

benjamin-confino commented Jan 5, 2026

View reviewed changes

dev/com.ibm.ws.cdi.weld/src/com/ibm/ws/cdi/liberty/CDIIntrospector.java Show resolved Hide resolved

create CDI introspector

87ba1ce

benjamin-confino force-pushed the cdi-introspector-2 branch from d807cfe to 87ba1ce Compare January 5, 2026 11:42

Azquelt reviewed Jan 5, 2026

View reviewed changes

benjamin-confino force-pushed the cdi-introspector-2 branch from 797bda6 to 478cfc3 Compare January 5, 2026 14:46

Azquelt reviewed Jan 5, 2026

View reviewed changes

benjamin-confino force-pushed the cdi-introspector-2 branch from 5eea727 to 6b84573 Compare January 5, 2026 16:15

Azquelt previously approved these changes Jan 5, 2026

View reviewed changes

benjamin-confino dismissed Azquelt’s stale review via 76acf1f January 5, 2026 21:44

Azquelt previously approved these changes Jan 6, 2026

View reviewed changes

benjamin-confino added 9 commits January 6, 2026 16:53

Update introspector output based on code review feedback

34ee3d4

add toString to WebSphereEEModuleDescriptor for introspection

a4cbeaa

Cleanup some comments

add introspect method to WebSphereBeanDeploymentArchive interface

d52cb3e

write out beans.xml contents during introspection

13e81c4

Correct spelling mistake in cdi introspector output

b309f06

update Component annotation on CDIINtrospector

a7d6107

Update beans xml introspection output as per code review comments

a54ca25

use URL that doesn't trigger prohibited terms check

e0db10a

update copyright

9412655

benjamin-confino dismissed Azquelt’s stale review via 9412655 January 6, 2026 16:58

benjamin-confino force-pushed the cdi-introspector-2 branch from 76acf1f to 9412655 Compare January 6, 2026 16:58

Azquelt approved these changes Jan 7, 2026

View reviewed changes

		if (beansXml != null)
		out.println("++++ beansXml:" + beansXml + "++++");

		@Component(immediate = true, configurationPolicy = ConfigurationPolicy.IGNORE, property = {
		Constants.SERVICE_VENDOR + "=" + "IBM" })

		String url = "beansXML URL: " + beansXml.getUrl();
		out.println("beansXML URL: " + url);

create CDI introspector #33740

Are you sure you want to change the base?

create CDI introspector #33740

Conversation

benjamin-confino commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Azquelt Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Azquelt Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benjamin-confino commented Jan 5, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Jan 5, 2026

Code analysis and actions

Uh oh!

LibbyBot commented Jan 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Azquelt Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Azquelt left a comment

Choose a reason for hiding this comment

Uh oh!

benjamin-confino commented Jan 5, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Jan 5, 2026

Code analysis and actions

Uh oh!

LibbyBot commented Jan 5, 2026

Uh oh!

benjamin-confino commented Jan 5, 2026 • edited by LibbyBot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LibbyBot commented Jan 5, 2026

Code analysis and actions

Uh oh!

Azquelt left a comment

Choose a reason for hiding this comment

Uh oh!

benjamin-confino commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

benjamin-confino commented Jan 5, 2026 •

edited

Loading

Azquelt Jan 5, 2026 •

edited

Loading

benjamin-confino commented Jan 5, 2026 •

edited by LibbyBot

Loading

benjamin-confino commented Jan 5, 2026 •

edited by LibbyBot

Loading

benjamin-confino commented Jan 5, 2026 •

edited by LibbyBot

Loading