fix(fs/storage-details): use used space#355
Merged
xrgzs merged 2 commits intoOpenListTeam:mainfrom Jan 8, 2026
Merged
Conversation
6 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the storage usage calculation logic to use a new used_space field directly from the backend instead of computing it as total_space - free_space. This change simplifies the calculation and allows the backend to provide the authoritative used space value.
Key changes:
- Added
used_spaceoptional field toMountDetailstype - Updated
toReadableUsageto useused_spacedirectly - Enhanced
usedPercentagewith additional null checks and edge case handling - Improved
showDiskUsagewith more robust null checking
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/types/obj.ts | Adds used_space optional field to MountDetails type to support direct used space reporting from backend |
| src/utils/storage.ts | Updates storage calculation functions to use used_space field with improved validation and edge case handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
xrgzs
approved these changes
Jan 8, 2026
fsca8
pushed a commit
to fsca8/OpenList-Frontend
that referenced
this pull request
Feb 20, 2026
* fix(fs/storage-details): show used space * Apply suggestion Signed-off-by: MadDogOwner <xiaoran@xrgzs.top> --------- Signed-off-by: MadDogOwner <xiaoran@xrgzs.top> Co-authored-by: MadDogOwner <xiaoran@xrgzs.top>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / 描述
驱动空间使用情况,改为使用总空间和已用空间计算进度条百分比/显示文本
Motivation and Context / 背景
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库(若适用)。