Report missing objects to server when not found in online index#222
Merged
Report missing objects to server when not found in online index#222
Conversation
Co-authored-by: LeftofZen <7483209+LeftofZen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add functionality to allow editor to add missing objects
Report missing objects to server when not found in online index
Dec 27, 2025
27018ef to
21b622f
Compare
LeftofZen
approved these changes
Dec 28, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds functionality for the ObjectEditor to report objects that are not found in the online index to the server's missing objects registry. When users attempt to download missing objects for a scenario and the server indicates some are not available, the editor now automatically reports these to the server for tracking purposes.
Key Changes
- Implemented client-side method to POST missing object entries to the server
- Enhanced scenario download workflow to report unfound objects
- Added integration test to verify missing objects are properly recorded in the database
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Definitions/Web/Client.cs |
Added AddMissingObjectAsync method to POST missing object entries to the /missing endpoint |
Gui/ObjectServiceClient.cs |
Exposed the AddMissingObjectAsync method for GUI layer consumption |
Gui/ViewModels/LocoTypes/SCV5ViewModel.cs |
Modified DownloadMissingObjects to report objects not found in online index and improved error logging with contextual information |
Tests/ObjectServiceIntegrationTests/ObjectRoutesTest.cs |
Added integration test AddMissingObjectAsync that verifies missing objects are created with correct availability status |
Tests/ObjectServiceIntegrationTests/BaseReferenceDataTableTestFixture.cs |
Refactored GetDbContext helper method to reduce code duplication in test setup |
Tests/ObjectServiceIntegrationTests/BaseReferenceDataTableTestFixture.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downloading missing objects for a scenario, the editor now reports objects not found in the online index to the server's missing objects registry.
Changes
Client layer (
Definitions/Web/Client.cs)AddMissingObjectAsyncto POSTDtoMissingObjectEntryto/missingendpointGUI client wrapper (
Gui/ObjectServiceClient.cs)AddMissingObjectAsyncmethodScenario view model (
Gui/ViewModels/LocoTypes/SCV5ViewModel.cs)DownloadMissingObjects()to report objects not found in online index:Tests (
Tests/ObjectServiceIntegrationTests/ObjectRoutesTest.cs)ObjectAvailability.MissingstatusThe server-side
/missingendpoint (AddMissingObjectinObjectRouteHandler.cs) was already implemented.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
av-build-tel-api-v1.avaloniaui.net/usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.1/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.1/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll(dns block)/usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.1/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.1/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll .cs ctService ndor/bin/git(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.