Migrate missing objects from ObjectAvailability enum to dedicated TblObjectMissing table

[Copilot]

Missing objects were stored as TblObject records with Availability = ObjectAvailability.Missing, mixing database storage concerns with availability states. This moves them to a dedicated TblObjectMissing table.

Changes

New table structure:

• Created TblObjectMissing with fields from DtoMissingObjectEntry: DatName, DatChecksum, ObjectType
• Added unique composite index on (DatName, DatChecksum)
• Registered as DbSet<TblObjectMissing> MissingObjects in LocoDbContext

Route handler updates:

• ObjectMissingRouteHandler: Now operates directly on MissingObjects table instead of filtering TblObject
• ObjectRouteHandler: Checks MissingObjects on upload and removes stale entries when actual object is provided

Before:

// Had to create full TblObject with all metadata, DatObjects, etc.
var tblObject = new TblObject() {
    Name = $"{entry.DatName}_{entry.DatChecksum}",
    Availability = ObjectAvailability.Missing,
    // ... 15+ more properties
};
db.Objects.Add(tblObject);
tblObject.DatObjects.Add(new TblDatObject() { /* ... */ });

After:

// Simple, focused on missing object data only
var tblObjectMissing = new TblObjectMissing() {
    DatName = entry.DatName,
    DatChecksum = entry.DatChecksum,
    ObjectType = entry.ObjectType,
};
db.MissingObjects.Add(tblObjectMissing);

Includes EF Core migration and updated tests. The ObjectAvailability.Missing enum value remains for potential future use but is no longer referenced in the codebase.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• av-build-tel-api-v1.avaloniaui.net
  • Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.1/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.1/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll (dns block)
  • Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.1/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.1/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll sharp/working/emptyFakeDotnetRoot 01CD7828DF338951F5/missingpackages_workingdir (dns block)
  • Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll get.config (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Missing objects in ObjectService project are currently stored as a value in the ObjectAvailability enum in TblObject and related classes. However these should be in a new and separate table, TblObjectMissing. Create the table design for this based on the DtoMissingObjectEntry, as well as revise ObjectMissingRouteHandler to use the new table

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

This PR successfully migrates missing objects from being stored as TblObject records with Availability = ObjectAvailability.Missing to a dedicated TblObjectMissing table, simplifying the data model and improving separation of concerns.

Key changes:

• Created new TblObjectMissing table with fields for DatName, DatChecksum, and ObjectType, with a unique composite index
• Introduced new DTOs: DtoObjectMissingEntry (with Id) and DtoObjectMissingUpload (without Id), replacing the former DtoMissingObjectEntry
• Updated ObjectMissingRouteHandler to operate directly on the new ObjectsMissing table
• Modified ObjectRouteHandler to check for and remove stale missing entries when actual objects are uploaded
• Added comprehensive integration tests for the missing objects routes

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Definitions/Database/DataTables/TblObjectMissing.cs	Defines new table class with composite unique index on DatName and DatChecksum
Definitions/Database/LocoDbContext.cs	Registers ObjectsMissing DbSet
Definitions/Migrations/20251228122835_AddTblObjectMissing.cs	EF Core migration creating ObjectsMissing table (also includes unrelated schema changes)
Definitions/DTO/DtoObjectMissingEntry.cs	New DTO for missing objects with Id field
Definitions/DTO/DtoObjectMissingUpload.cs	Renamed from DtoMissingObjectEntry, used for POST requests
Definitions/DTO/Mappers/DtoExtensions.cs	Added mapping methods between TblObjectMissing and DTOs
Definitions/DTO/Comparers/*.cs	Updated comparers for renamed/new DTO types
ObjectService/RouteHandlers/TableHandlers/ObjectMissingRouteHandler.cs	Completely rewritten to use ObjectsMissing table instead of filtering Objects
ObjectService/RouteHandlers/TableHandlers/ObjectRouteHandler.cs	Checks and removes missing entries when actual object is uploaded
Gui/ObjectServiceClient.cs	Updated return type to DtoObjectMissingEntry for AddMissingObjectAsync
Gui/ViewModels/LocoTypes/SCV5ViewModel.cs	Updated to use new DTO types and improved logging format
Definitions/Web/Client.cs	Updated AddMissingObjectAsync signature to return DtoObjectMissingEntry
Tests/ObjectServiceIntegrationTests/ObjectMissingRoutesTest.cs	New comprehensive integration tests for missing objects CRUD operations
Tests/ObjectServiceIntegrationTests/ObjectRoutesTest.cs	Removed obsolete AddMissingObjectAsync test

Files not reviewed (1)

• Definitions/Migrations/20251228122835_AddTblObjectMissing.Designer.cs: Language not supported