Image table grouping for vehicles

[LeftofZen]

No description provided.

[Copilot]

Pull request overview

This PR implements image table grouping functionality for vehicle objects, improving the organization and categorization of vehicle sprites in the ObjectEditor. The changes include renaming and clarifying sprite-related properties and flags, implementing a comprehensive vehicle image grouping algorithm, and updating the test infrastructure to support the new data structure.

Key changes:

• Added comprehensive image table grouping for vehicle body and bogie sprites with support for different orientations and slopes
• Renamed BogieSprite.RollStates to NumAnimationFrames for clarity and removed unused NumRollSprites property
• Updated BogieSpriteFlags enum to clarify flag meanings and remove deprecated flags
• Refactored GetViewModelFromStruct to accept LocoObject instead of ILocoStruct for better context access

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
Tests/IdempotenceTests.cs	Updated test to work with refactored GetViewModelFromStruct signature that now accepts LocoObject
Gui/ViewModels/LocoTypes/Objects/Vehicle/VehicleViewModel.cs	Added empty VehicleComponentsViewModel class, moved namespace, added enum prohibit value attributes for sprites, removed unused import
Gui/ViewModels/LocoTypes/Objects/Building/BuildingViewModel.cs	Added blank line for formatting consistency
Gui/ViewModels/LocoTypes/ObjectEditorViewModel.cs	Refactored GetViewModelFromStruct to accept LocoObject, reorganized null assignments for better code flow
Definitions/ObjectModels/Objects/Vehicle/BogieSpriteFlags.cs	Removed deprecated flags and updated comments for clarity on remaining flags
Definitions/ObjectModels/Objects/Vehicle/BogieSprite.cs	Renamed RollStates to NumAnimationFrames, removed NumRollSprites, added Browsable(false) attributes, updated validation
Definitions/ObjectModels/Objects/Vehicle/BodySpriteFlags.cs	Updated flag comments for clarity and marked deprecated flag
Definitions/ObjectModels/Objects/Vehicle/BodySprite.cs	Added documentation comment explaining computed properties
Definitions/ObjectModels/Graphics/ImageTableGrouper.cs	Implemented comprehensive vehicle image grouping with support for body and bogie sprites across different slopes and orientations
Dat/Loaders/Vehicle/VehicleObjectLoader.cs	Added comment noting skipped additional image table setup
Dat/FileParsing/LocoBinaryWriter.cs	Updated to write NumAnimationFrames and placeholder byte instead of NumRollSprites
Dat/FileParsing/LocoBinaryReader.cs	Updated to read NumAnimationFrames and skip placeholder byte instead of reading NumRollSprites

Comments suppressed due to low confidence (1)

Gui/ViewModels/LocoTypes/Objects/Vehicle/VehicleViewModel.cs:24

• An empty class VehicleComponentsViewModel has been added but contains no implementation. Empty classes add no value and should either be implemented or removed. If this is a placeholder for future work, it should not be committed until it has actual functionality.