Skip to content

Conversation

@t0mdavid-m
Copy link
Member

@t0mdavid-m t0mdavid-m commented Aug 23, 2025

This PR adds the example data for the TDP Symposium 2025 Workshop.

Summary by CodeRabbit

  • New Features

    • Added ready-to-run workshop sample data and presets for FLASHDeconv and FLASHTnT, including example parameters, feature tables, and deconvolved spectra to help users explore workflows without setup.
    • Included configuration templates (.ini and JSON) to simplify tuning tolerances, charges, ion types, and FDR options.
  • Chores

    • Bumped app version to 0.9.6.
    • Updated Windows installer naming to reflect the new version.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 23, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Bumps app/version identifiers to 0.9.6 and adds workshop example datasets and configurations for FLASHDeconv and FLASHTnT. New INI and JSON parameter files plus multiple cached feature and mzML artifacts are introduced under example-data/workspaces/workshop/*, without code or control-flow changes.

Changes

Cohort / File(s) Change summary
CI/version bump
.github/workflows/build-windows-executable-app.yaml, settings.json
Updated APP_NAME from FLASHApp-0.9.5 to FLASHApp-0.9.6 and settings.json version from 0.9.5 to 0.9.6.
Workshop configs (FLASHDeconv + FLASHTnT)
example-data/workspaces/workshop/flashdeconv/ini/FLASHDeconv.ini, example-data/workspaces/workshop/flashtnt/ini/FLASHDeconv.ini, example-data/workspaces/workshop/flashtnt/ini/FLASHTnT.ini
Added OpenMS Param XML INI files defining full configuration schemas for FLASHDeconv and FLASHTnT.
Workshop params
example-data/workspaces/workshop/params.json
Added workspace-level UI/config defaults (selected files, image format, intensity cutoff, dimensions, flag).
FLASHDeconv params
example-data/workspaces/workshop/flashdeconv/params.json
Added JSON params for FLASHDeconv: mzML path, threads, SD:tol, FD:report_FDR.
FLASHTnT params
example-data/workspaces/workshop/flashtnt/params.json
Added JSON params for FLASHTnT workflow: mzML/FASTA paths, threads, few_proteins, FLASHDeconv SD settings, FLASHTnT ion/tag/FDR settings.
FLASHDeconv cache (2025-05-25)
example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250525-204033/FD_parameters.json, .../toppic_ms1.feature, .../toppic_ms2.feature
Added cached parameter JSON and TOPPIC MS1/MS2 feature tables for example_fd.mzML (205 MS1 features, 186 MS2 rows).
FLASHDeconv cache (2025-08-23)
example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250823-152120/FD_parameters.json, .../toppic_ms1.feature, .../toppic_ms2.feature
Added cached parameter JSON and TOPPIC MS1/MS2 feature tables for example_fd.mzML (401 MS1 features, 191 MS2 data rows plus header).
FLASHTnT cache: example_fd (2025-08-23)
example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/FD_parameters.json, .../FTnT_parameters.json, .../toppic_ms1.feature, .../toppic_ms2.feature
Added SD and FTnT parameter JSONs; added TOPPIC MS1 (397 rows) and MS2 (188 rows) feature files for example_fd.mzML.
FLASHTnT cache: antibody (2025-05-25)
example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/FD_parameters.json, .../FTnT_parameters.json, .../out_deconv.mzML, .../toppic_ms2.feature, .../toppic_ms2.msalign
Added SD/FTnT parameter JSONs; added deconvolved mzML, MS2 feature header, and msalign with one spectrum.
FLASHTnT cache: aqpz (2025-05-25)
example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/FD_parameters.json, .../FTnT_parameters.json, .../out_deconv.mzML, .../toppic_ms2.feature, .../toppic_ms2.msalign
Added SD/FTnT parameter JSONs; added deconvolved mzML, MS2 feature header, and msalign with one spectrum.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A whisk of versions—0.9.6 anew,
I thump my paws on data’s dew.
INIs bloom, JSONs align,
Features march in tidy line.
mzML moons glow byte-bright night—
Hippity-hop, we cache it right! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5f3afa0 and 6bfb55b.

⛔ Files ignored due to path filters (55)
  • example-data/workspaces/workshop/flashdeconv/cache/cache.db is excluded by !**/*.db
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250525-204033/FD_parameters.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250525-204033/out.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250525-204033/quant.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250525-204033/spec1.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250525-204033/spec2.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250823-152120/FD_parameters.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250823-152120/out.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250823-152120/quant.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250823-152120/spec1.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250823-152120/spec2.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashdeconv/logs/all.log is excluded by !**/*.log
  • example-data/workspaces/workshop/flashdeconv/logs/commands-and-run-times.log is excluded by !**/*.log
  • example-data/workspaces/workshop/flashdeconv/logs/minimal.log is excluded by !**/*.log
  • example-data/workspaces/workshop/flashquant/cache/cache.db is excluded by !**/*.db
  • example-data/workspaces/workshop/flashquant/cache/files/example/conflict_tsv.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashquant/cache/files/example/quant_tsv.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashquant/cache/files/example/trace_tsv.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/cache.db is excluded by !**/*.db
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/FD_parameters.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/FTnT_parameters.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/internal_fragment_data.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/out.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/protein.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/prsms.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/quant.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/sequence_data.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/settings.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/spec1.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/spec2.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/tags.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/FD_parameters.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/FTnT_parameters.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/internal_fragment_data.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/protein.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/prsms.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/quant.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/sequence_data.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/settings.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/spec2.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/tags.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/FD_parameters.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/FTnT_parameters.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/internal_fragment_data.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/protein.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/prsms.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/quant.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/sequence_data.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/settings.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/spec2.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/tags.tsv is excluded by !**/*.tsv
  • example-data/workspaces/workshop/flashtnt/cache/files/layout/layout.pkl.gz is excluded by !**/*.gz
  • example-data/workspaces/workshop/flashtnt/logs/all.log is excluded by !**/*.log
  • example-data/workspaces/workshop/flashtnt/logs/commands-and-run-times.log is excluded by !**/*.log
  • example-data/workspaces/workshop/flashtnt/logs/minimal.log is excluded by !**/*.log
📒 Files selected for processing (28)
  • .github/workflows/build-windows-executable-app.yaml (1 hunks)
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250525-204033/FD_parameters.json (1 hunks)
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250525-204033/toppic_ms1.feature (1 hunks)
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250525-204033/toppic_ms2.feature (1 hunks)
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250823-152120/FD_parameters.json (1 hunks)
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250823-152120/toppic_ms1.feature (1 hunks)
  • example-data/workspaces/workshop/flashdeconv/cache/files/example_fd_20250823-152120/toppic_ms2.feature (1 hunks)
  • example-data/workspaces/workshop/flashdeconv/ini/FLASHDeconv.ini (1 hunks)
  • example-data/workspaces/workshop/flashdeconv/params.json (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/FD_parameters.json (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/FTnT_parameters.json (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/toppic_ms1.feature (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_fd_20250823-151911/toppic_ms2.feature (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/FD_parameters.json (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/FTnT_parameters.json (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/out_deconv.mzML (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/toppic_ms2.feature (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_antibody_20250525-204021/toppic_ms2.msalign (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/FD_parameters.json (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/FTnT_parameters.json (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/out_deconv.mzML (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/toppic_ms2.feature (1 hunks)
  • example-data/workspaces/workshop/flashtnt/cache/files/example_spectrum_aqpz_20250525-203956/toppic_ms2.msalign (1 hunks)
  • example-data/workspaces/workshop/flashtnt/ini/FLASHDeconv.ini (1 hunks)
  • example-data/workspaces/workshop/flashtnt/ini/FLASHTnT.ini (1 hunks)
  • example-data/workspaces/workshop/flashtnt/params.json (1 hunks)
  • example-data/workspaces/workshop/params.json (1 hunks)
  • settings.json (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix_bugs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@t0mdavid-m t0mdavid-m merged commit 2e66cc8 into develop Aug 23, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants