Address review comments by @greengypsy #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trickyck
reviewed
Jun 8, 2022
|
|
||
| OpenMS is meant to run and behave the same on the three main operating systems, i.e., Windows, macOS and Linux. Adding | ||
| a new dependent library is thus required to be available on these platforms | ||
| OpenMS has been designed for the following platforms, i.e., Windows, macOS and Linux. Therefore, the new dependency |
Contributor
There was a problem hiding this comment.
Do we need i.e.? Can we just say "for the following platforms: Windows, macOS and Linux"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #65.
Describe the change
PR checklist
CHANGELOG.mdis updated.