Skip to content

Address review comments by @enetz and @jpfeuffer #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tapaswenipathak merged 1 commit into from
Jun 8, 2022
Merged

Address review comments by @enetz and @jpfeuffer #83

tapaswenipathak merged 1 commit into from
Jun 8, 2022

Conversation

@tapaswenipathak
Copy link
Contributor

@tapaswenipathak tapaswenipathak commented Jun 8, 2022 •
edited
Loading

Ref #65.

Describe the change

PR checklist

@tapaswenipathak tapaswenipathak self-assigned this Jun 8, 2022
jpfeuffer
jpfeuffer approved these changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@jpfeuffer jpfeuffer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! The detailed descriptions about Cmake build type etc, are they going into the developer documentation?

@tapaswenipathak
Copy link
Contributor Author

tapaswenipathak commented Jun 8, 2022

Very nice! The detailed descriptions about Cmake build type etc, are they going into the developer documentation?

yes.

@tapaswenipathak tapaswenipathak merged commit a6c592b into OpenMS:staging Jun 8, 2022
@tapaswenipathak tapaswenipathak deleted the pr-65-review-@enetz-and-@jpfeuffer branch June 8, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpfeuffer jpfeuffer jpfeuffer approved these changes

+1 more reviewer

@enetz enetz enetz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tapaswenipathak tapaswenipathak

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tapaswenipathak @jpfeuffer @enetz