Skip to content

Conversation

@poshul
Copy link
Contributor

@poshul poshul commented Dec 4, 2025

Summary by CodeRabbit

Chores

  • Enabled static library support for Arrow library builds across all platforms
  • Improved relocatability of Arrow and Parquet CMake configuration files by converting absolute build paths to relative paths, ensuring proper functionality when libraries are installed in different directories

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The Arrow CMake configuration was updated to enable static library builds and fix relocatability by converting absolute build paths to relative paths in both MSVC and non-MSVC build configurations. A status message confirms these CMake config fixes were applied.

Changes

Cohort / File(s) Summary
Arrow CMake Configuration
libraries.cmake/arrow.cmake
Added ARROW_BUILD_STATIC=ON flag to enable static library support; converted absolute paths to relative paths in ArrowTargets*.cmake and ParquetTargets*.cmake using import-prefix for relocatability in both MSVC and non-MSVC branches; added status message confirmation

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Straightforward CMake configuration changes following a consistent pattern
  • Path transformation logic applied symmetrically across MSVC and non-MSVC branches
  • No complex logic or multi-file dependencies to evaluate

Poem

🐰 A rabbit hops through CMake with glee,
Static paths now dance so free!
From absolute to relative ways,
Arrow's targets bloom through all our days.
Thump-thump—relocatable dreams come true! 📦

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch more_arrow_bullshit

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a536f21 and 66fddab.

📒 Files selected for processing (1)
  • libraries.cmake/arrow.cmake (4 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@poshul poshul merged commit b41c2c5 into master Dec 4, 2025
5 of 6 checks passed
This was referenced Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants