Skip to content

Conversation

@trickyck
Copy link
Contributor

@trickyck trickyck commented May 24, 2022

Adding faq from wiki to pyopenms-docs.

Closes #281.

.. contents:: The following is a list of common questions asked about pyOpenMS.

How can I wrap a new method with pyOpenMS?
###########################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow existing formatting style guide for pyopenms-docs .rst:
Screenshot 2022-05-24 at 4 09 30 PM

Change headings formattings to the one discussed.
How can I wrap a new class with pyOpenMS?
#########################################

Create a new file ``src/pyOpenMS/pxds/CLASS_NAME.pxd`` and use the `procedure outlined <https://github.com/OpenMS/OpenMS/wiki/pyOpenMS#--wrapping-classes>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of wiki, let's link to the page on pyopenms.readthedocs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,22 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's delete this newline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

How can I wrap a new class with pyOpenMS?
-----------------------------------------

Create a new file ``src/pyOpenMS/pxds/CLASS_NAME.pxd`` and use the `procedure outlined <https://pyopenms.readthedocs.io/en/latest/wrap_classes.html?#how-pyopenms-wraps-python-classes>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was not clear: let's link it to: wrap_classes.rst#how-to-wrap-new-classes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tapaswenipathak
Copy link
Contributor

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@timosachsenberg
Copy link
Contributor

Thanks!

@timosachsenberg timosachsenberg merged commit 5e59a17 into OpenMS:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyOpenMS docs doesn't have an FAQ page

3 participants