Use Windows 2022 Runner

[t0mdavid-m]

More consistency with OpenMS CI build

Summary by CodeRabbit

• Chores
  • Updated Windows build environment to Windows Server 2022 for build pipelines, improving build consistency and reliability.
  • No changes to application features or behavior.

[coderabbitai]

Walkthrough

Updated GitHub Actions workflow to use the windows-2022 runner image for the build-openms and build-executable jobs.

Changes

Cohort / File(s)	Summary of Changes
CI Workflow Runner Update \.github/workflows/build-windows-executable-app.yaml	Changed runs-on from windows-latest to windows-2022 for jobs: build-openms, build-executable. No other modifications detected.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny taps the CI keys with grace,
Swaps windows-latest for 2022’s place.
Pipelines hop steady, no extra fuss,
Carrots aligned for each build bus.
Thump-thump—green checks race! 🥕✅

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Use Windows 2022 Runner" succinctly and accurately reflects the primary change in the diff — replacing the GitHub Actions runner from windows-latest to windows-2022 for the build-openms and build-executable jobs — and is specific and clear enough for a teammate scanning PR history to understand the main intent.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch windows_2022

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/build-windows-executable-app.yaml (1)

188-188: Runner pin LGTM; watch for shell/tool availability in this job.

Minor risk: a few steps rely on Unix utils without forcing Bash. Example: Line 251 uses sed but the step runs in PowerShell by default; also unzip is used in multiple PowerShell steps. To harden against image differences:

• Prefer explicit shells per step (Bash when using sed/Unix tools), or
• Replace with native PowerShell.

Example fixes (outside this hunk):

• Force Bash for sed:

  - name: Uncomment 'import site' in python311._pth file
    shell: bash
    run: sed -i 's/#import site/import site/' python-${{ env.PYTHON_VERSION }}/python311._pth

• Or PowerShell-native:

  - name: Uncomment 'import site' in python311._pth file
    run: (Get-Content "python-${{ env.PYTHON_VERSION }}/python311._pth") -replace '#import site','import site' | Set-Content "python-${{ env.PYTHON_VERSION }}/python311._pth"

• Replace unzip with 7z (already used elsewhere):

  run: |
    7z x "*.zip" -y -o.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89e26a0 and 0d43909.

📒 Files selected for processing (1)

• .github/workflows/build-windows-executable-app.yaml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: build-openms
• GitHub Check: build-simple-app
• GitHub Check: test (ubuntu-latest, 3.11)

🔇 Additional comments (1)

.github/workflows/build-windows-executable-app.yaml (1)

27-27: Pinning to windows-2022 aligns with the PR goal.

Looks good. Please sanity‑check toolchain assumptions on this image (VS 2022 picked by vs-shell, 7z present, gh on PATH) during the next run to avoid environment surprises.