lapack-3.4.0 -> 3.4.1 upgrade

[jpsinthemix]

Hi,

I build openblas w/lapack for use in octave, scipy, numpy, etc. The openblas-0.1.0 build is fine, but a number of octave tests (related to qr.cc. qz.cc, and svd.cc) fail due to a bug in the lapack-3.4.0 routines [d|s|c|z]gesvd_. This bug appears to have been fixed in lapack-3.4.1; refs:

http://savannah.gnu.org/bugs/?35596
http://www.netlib.org/lapack/errata_from_340_to_341.html (see bug0085)

I modified openblas-0.1.0/Makefile and adapted the lapack patch openblas-0.1.0/patch.for_lapack-3.4.0 for use in lapack-3.4.1, rebuilt openblas-0.1.0 successfully, and now all octave tests pass.

I would attach the patch I used for upgrading openblas-0.1.0/Makefile to lapack-3.4.1 along with the new lapack patch file patch.for_lapack-3.4.1 I created but I don't know how to do so here..

Again, openblas itself is fine, and I really appreciate all the work you've done on this.

thanks much,
John

[xianyi]

Hi John,

Thank you for your patch at advance.

We also changed patch.for_lapack-3.4.0 on develop branch. You can checkout the codes from this link https://github.com/xianyi/OpenBLAS/tree/develop

We fixed some bugs and supported LAPACKE interface in LAPACK-3.4.0 version. Thus, I suggest you make the patch based on our develop branch.

Here are 2 ways to submit the patch.

1. You can use gist (https://gist.github.com/) to send me the patch file.
   Or
2. You can fork openblas into your own github project. Then, you can commit your patch into your own project. Next, you should use "pull request" on github.

Thank you again! :)

Xianyi

[jpsinthemix]

On 04/22/2012 12:03 AM, Xianyi Zhang wrote:

Hi John,

Thank you for your patch at advance.

We also changed patch.for_lapack-3.4.0 on develop branch. You can checkout the codes from this link https://github.com/xianyi/OpenBLAS/tree/develop

We fixed some bugs and supported LAPACKE interface in LAPACK-3.4.0 version. Thus, I suggest you make the patch based on our develop branch.

Here are 2 ways to submit the patch.

1. You can use gist (https://gist.github.com/) to send me the patch file.
   Or
2. You can fork openblas into your own github project. Then, you can commit your patch into your own project. Next, you should use "pull request" on github.

Thank you again! :)

Xianyi

---

Reply to this email directly or view it on GitHub:
#93 (comment)

Hi Xianyi,
As I'm kinda busy now, it much easier for me to simply post the patches
using gist. So I've done so and they are at
https://gist.github.com/2463468

I am working with a git clone with the most recent commit:

commit 09f74f6
Merge: fda39c6 2b3eae6
Author: Xianyi Zhang traits.zhang@gmail.com
Date: Fri Mar 23 18:52:40 2012 +0800

 Merge branch 'release-0.1.0'

so I think this is current. Hope the patches help, and thanks again.

PS. If/when I come across what might be an openblas code issue, I'll try
and do a git pull/push.

[ViralBShah]

Currently, we see tests related to dgeqp3_ failing in julia due to inability to find the symbol in the openblas compiled with LAPACK. Is this related to a similar issue?

[xianyi]

Hi Viral,

Could you try develop branch?
OpenBLAS 0.1.0 version has a bug about missing some LAPACK functions. I already fixed this bug on develop branch.

Thanks

Xianyi

[zchothia]

Hello,

Here is an updated patch which applies to the develop branch: https://gist.github.com/2469388.
Tested and working on Ubuntu 12.04 and Windows (MinGW).

--Zaheer

[xianyi]

Hi Zaheer,

Thank you very much.

I just started to upgrade lapack version. Then, I got your patch. :-)

Xianyi