Scan full file for MD5 hash to pick up all Ogre changes. #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scanning the first 1024 bytes was causing some Ogre file changes not to be detected (e.g. alterations in a large text file that don't alter length). The whole file is now hashed, and the filename salting has been removed. This is the same method used in the new Ogre updater, and is as fast or faster than the existing method of scanning (code used is directly from the Ogre updater).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scanning only the first 1024 bytes was causing some Ogre file changes not
to be detected (e.g. alterations in a large text file that don't change file length).
The whole file is now hashed, and the filename salting has been removed.
This is the same method used in the new Ogre updater, and is as fast or
faster than the existing method of scanning (code used is directly from the
Ogre updater).
If you decide to use this change to the patcher we should coordinate the
release so 112 can update their patchinfo.txt at the same time.