-
Notifications
You must be signed in to change notification settings - Fork 23
Move PetriNets, PowerSystems and SystemDynamics to core libraries #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sjoelund
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we really going to ship 2 copies of PowerSystems? Latest release should be fine, no?
sjoelund
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makefile.libs is automatically generated from repos.json. Probably need to change the source or the changes disappear
I guess 1.0.0 should be fine. 0.6.0 had some issues that were fixed, it probably doesn't work well in OpenModelica anyway. |
|
@rfranke, what do you think? |
1.0.0 tag or the latest (whatever in the master). |
I thought the same but then Makefile.libs is in the repo. |
|
Yes, it's in the repo because we don't want to run the script to fetch all the information from GitHub on every build of OM. This way every system gets the same versions of the libraries as well. |
|
As discussed today, please use the master branch of PowerSystems. |
|
There are conflicts :) |
|
It shows me "This branch has no conflicts with the base branch. Merging can be performed automatically." |
|
Anyway I merged in origin/master. We can now squash and merge. |
|
Still no :) |
|
Now I could... |
No description provided.