Fixing the packges build and github workflows#55
Conversation
…l packages to clean up unused dependencies
… scripts for improved build process
…s and streamline dependency installation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes package builds and GitHub workflows by introducing a structured build system and modernizing CI/CD configurations. The changes implement a sequential/parallel package build order and update workflow configurations for better dependency management.
- Adds a new TypeScript build script that handles package dependencies and parallel builds
- Updates package.json scripts to use workspace filtering and removes redundant commands
- Modernizes GitHub workflow configurations with proper environment variables and cleaner step definitions
Reviewed Changes
Copilot reviewed 5 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/build.ts | New build orchestration script defining package build order and parallel execution |
| packages/song/package.json | Reorganizes dependencies and adds jszip dependency |
| package.json | Simplifies scripts using workspace filtering and adds build automation |
| .github/workflows/tests.yml | Adds environment variable and cleans up step descriptions |
| .github/workflows/lint.yml | Fixes duplicate install steps and adds proper GitHub token configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ntation route from '/api/doc' to '/docs' for consistency
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Bentroen
left a comment
There was a problem hiding this comment.
Thank you for the pull request! The build command is much cleaner now, and it's much easier to visualize the dependency structure between the internal packages. ✨
As a general question, would it be possible to tidy up the run command to avoid the nominal reference to the frontend and backend packages, using something like --filter /apps/* (just like we do with Bun)?
If not, it's entirely fine to leave it as-is. Asking just to know if we could make it 'aware' of our new workspace's organization — one of the largest benefits of working with a monorepo —, so we can take full advantage of it.
Also, I've noticed some dependency and import changes in other parts of the project — are they related to the change at hand? If not, I'd suggest making them in a separate PR in the future, just to keep things focused :)
We can definitely use workspace filtering. I will explore it and improve this PR
You're right to point that out. Those changes were fixes for issues I had introduced in a previous sloppy PR :S, the CI would not pass without it. Apologies for the noise. |
|
I understand we're juggling many responsibilities at the moment! The slips are entirely fine. Once our refactoring initiative is complete, I believe it'll make it much easier to make PRs self-contained with only the relevant changes! :) |
…t processes, adding support for apps and refining existing commands
|
I have updated the root package.json to use more of Bun's workspace features |
This update fixes our build and automation systems by:
./scripts/build.tsscript.