chore: Review formatting and linting rules + add pre-commit hook#58
Merged
tomast1337 merged 38 commits intodevelopfrom Oct 5, 2025
Merged
chore: Review formatting and linting rules + add pre-commit hook#58tomast1337 merged 38 commits intodevelopfrom
tomast1337 merged 38 commits intodevelopfrom
Conversation
…e ESLint configuration for improved rule management
It's preferable we re-add this package when E2E tests are actually implemented.
28 tasks
…in EditSong context
tomast1337
approved these changes
Sep 30, 2025
Bentroen
commented
Oct 5, 2025
Member
Author
Bentroen
left a comment
There was a problem hiding this comment.
Awesome work!
I've left a few changes, once these are done, it's fine to merge this PR.
apps/frontend/src/modules/shared/components/client/ads/AdSlots.tsx
Outdated
Show resolved
Hide resolved
Log ad loading errors to the console for debugging.
Removed the steps for checking changes and committing linter fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR thoroughly reviews the project's linting and formatting configurations to cover previously unaddressed cases, clearly separate linting and formatting responsibilities, and ensure that checked code adheres to the specified guidelines.
The goal of these changes is to make following the code style a natural part of the development workflow, avoiding the need for contributors to go out of their way to ensure these guidelines are followed. This should reduce the number of future linting commits and decrease the amount of time spent in future codebase reviews.
The added configurations were largely based in Open Collective's frontend and API repositories.
List of Changes
typescript-eslint), removing outdated@typescript-eslint/parserand@typescript-eslint/eslint-plugindependencieseslint-config-prettierandeslint-plugin-prettier(see: What about formatting?)huskyandlint-stagedto run Prettier on Git staged files before committing--ignore-unknownoptioneslint-plugin-import(had been removed when migrating to ESLint 8)@nbw/**modules as internal rather than third-party.prettierignoreto specify exception cases to Prettier formatting.hbsemail template format: Prettier doesn't support them and collapses inline CSS in thestyletag to a single block.eslint.config.jsfile to.mjsto enforce ESM-like syntaxOther misc changes:
tests/package (can be re-added in the future once end-to-end tests are implemented)startscripts (@nbsinstead of@nbw)TODO
printWidthsetting from 80 to 100, and re-linting the codeprettier-plugin-tailwind-cssto automatically sort Tailwind classeseslint-plugin-importtoprettier-plugin-sort-importsorprettier-plugin-organize-importsSince the changes above are ready to be merged, these changes may be incorporated in a future pull request as to prevent holding back these changes (long-lived pull requests are tricky!)