Fixes for compiling under OSX 10.8 with clang#35
Open
ChristianFrisson wants to merge 1 commit intoOpenNI:masterfrom
Open
Fixes for compiling under OSX 10.8 with clang#35ChristianFrisson wants to merge 1 commit intoOpenNI:masterfrom
ChristianFrisson wants to merge 1 commit intoOpenNI:masterfrom
Conversation
…(clang-425.0.28) (based on LLVM 3.2svn) that uses -Werror,-Wunused-private-field
Collaborator
|
IMHO, disallowing ANY unused private field is too strict and counter-productive especially when the code is in the beta status. As you rightly say it is a "hack", promoting private to protected just because the compiler complains does not make sense. I think the reasonable solution is "not" to treat unused private field as an error. Perhaps -Wno-error=unused-private-field would work? |
|
Hi, ing4shubowei |
|
You can work around this with make ALLOW_WARNINGS=1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Some private fields in OpenNI2 classes are colliding with Apple LLVM version 4.2 (clang-425.0.28) (based on LLVM 3.2svn) that uses -Werror,-Wunused-private-field. So as to make OpenNI2 compile, it did 2 kinds of hacks:
I don't know about the OpenNI2 architecture, hence the hacks. Could you please review these?
Best regards,
Christian