NMS-19270: Rest API for SNMP Config, Lookup and Add/Remove Definitions #8216
+737
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synqotik
changed the title
synqotik
force-pushed
the
jira/NMS-19270-rest-get-snmp-config
branch
from
587cb76 to
c3a58c8
Compare
cgorantla
reviewed
Dec 24, 2025
| } | ||
|
|
||
| // If a non-default location was specified, check if it is a valid monitoring location | ||
| final List<OnmsMonitoringLocation> locationList = monitoringLocationDao.findAll(); |
Contributor
There was a problem hiding this comment.
I think we can use monitoringLocationDao.get here.
| private String convertToValidLocation(String location) { | ||
| final boolean isDefaultLocation = Strings.isNullOrEmpty(location) || location.equalsIgnoreCase(MonitoringLocationDao.DEFAULT_MONITORING_LOCATION_ID); | ||
|
|
||
| if (isDefaultLocation) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (isDefaultLocation) { | |
| if (MonitoringLocationUtils.isDefaultLocationName(location)) { |
Comment on lines
+247
to
+248
| } catch (Exception ignored) { | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| } catch (Exception ignored) { | |
| } | |
| } catch (Exception ignored) { | |
| LOG.debug("Invalid IP address: {}", ipAddress, e); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rest API for SNMP Config where the config is in the DB (via CM).
Covered in this PR:
(Note, all these also include monitoring location.)
Added integration tests. The one for
addDefinitionwas failing locally, I will fix it subsequently (the actual Rest API is working). Wanted to get this PR merged so I can continue with the UI.Add/remove profiles will be done separately.
External References