Handling unrecoverable ABRT signals in HDF5 Library#126
Merged
selimnairb merged 8 commits intoOpenNavigationSurface:masterfrom Nov 8, 2024
Merged
Handling unrecoverable ABRT signals in HDF5 Library#126selimnairb merged 8 commits intoOpenNavigationSurface:masterfrom
selimnairb merged 8 commits intoOpenNavigationSurface:masterfrom
Conversation
… checking" This reverts commit fc62957.
Collaborator
|
@anthonypapetti Thanks for contributing this. The tests pass (except for the reporter, which I expect to fail since this is a PR; need to fix that to not run for PRs). Going to merge. |
Contributor
Author
|
@selimnairb Found afterwards that this also fixes #81 , will update if I find any more that is fixed by it. |
Contributor
Author
|
@selimnairb Found that it fixes #103 #79 #93 |
akshitamav
reviewed
Nov 15, 2024
| @@ -859,6 +859,7 @@ bool decodeDataQualityInfo( | |||
| else if (schemaVersion == 2) | |||
| { | |||
| //gmd:DQ_DataQuality/gmd:scope/gmd:DQ_Scope/gmd:level | |||
There was a problem hiding this comment.
Would it be better here to change BagDataQuality::scope to be a std::string instead of a char*? It would mean we wouldn't have to use delete[] manually everywhere, which might also help with bugs
akshitamav
reviewed
Nov 15, 2024
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118 #117 #84 #80
This commit adds error handling using std::signal to catch SIGABRT signals from the HDF5 Library in bag_dataset.cpp and exit the program gracefully.