Included CEPH_USER attr from datastore to be used by ONE Ceph remotes#33
Closed
alvarosimon wants to merge 3 commits intoOpenNebula:masterfrom
Closed
Included CEPH_USER attr from datastore to be used by ONE Ceph remotes#33alvarosimon wants to merge 3 commits intoOpenNebula:masterfrom
alvarosimon wants to merge 3 commits intoOpenNebula:masterfrom
Conversation
… and CEPH_USER from the datastore template. At this moment all Ceph remotes are using Ceph admin privileges. This could be a sec. issue, CEPH_USER should be a mandatory param into Ceph datastores and it should be used by Ceph remotes by default.
Contributor
|
We would need this to default to the old behaviour if CEPH_USER is not specified. Before doing any work, let me see if making it backwards compatible that would guarantee the inclusion into 4.8.1, I need to discuss it with the team. Thanks a lot!! |
Contributor
Author
|
@jmelis Thanks a lot!, we have also included a pull request for the documentation OpenNebula/docs#12 |
Contributor
Author
|
@jmelis we have changed the code to be backwards compatible. Now if the CEPH_USER att is set into ceph datatore the $RBD command is changed accordingly. This way the patch will be backwards compatible. ../tm/ceph/* scripts were also modified. This will improve the security if CEPH_USER and cephx sec are set. |
Member
|
This is now in master. THANKS for the commits!!!!!!!!! |
rsmontero
pushed a commit
that referenced
this pull request
Jun 22, 2020
rsmontero
pushed a commit
that referenced
this pull request
Jun 22, 2020
rsmontero
pushed a commit
that referenced
this pull request
Oct 6, 2020
rsmontero
pushed a commit
that referenced
this pull request
Apr 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified 2 lines and rados command to take into account the POOL_NAME and CEPH_USER from the datastore template.
At this moment all Ceph remotes are using Ceph admin privileges. This could be a sec. issue, CEPH_USER should be a mandatory param into Ceph datastores and it should be used by Ceph remotes by default.