Skip to content

Use training_step for W&B x-axis to allow out-of-order logging #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corbt merged 1 commit into from
Jan 19, 2026
+7 −6
Merged

Use training_step for W&B x-axis to allow out-of-order logging #512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/art/local/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,12 +658,7 @@ def _log_metrics(

# If we have a W&B run, log the data there
if run := self._get_wandb_run(model):
# Mark the step metric itself as hidden so W&B doesn't create an automatic chart for it
wandb.define_metric("training_step", hidden=True)

# Enabling the following line will cause W&B to use the training_step metric as the x-axis for all metrics
# wandb.define_metric(f"{split}/*", step_metric="training_step")
run.log({"training_step": step, **metrics}, step=step)
run.log({"training_step": step, **metrics})

def _get_wandb_run(self, model: Model) -> Run | None:
if "WANDB_API_KEY" not in os.environ:
Expand All @@ -688,6 +683,12 @@ def _get_wandb_run(self, model: Model) -> Run | None:
),
)
self._wandb_runs[model.name] = run

# Define training_step as the x-axis for all metrics.
# This allows out-of-order logging (e.g., async validation for previous steps).
wandb.define_metric("training_step")
wandb.define_metric("train/*", step_metric="training_step")
wandb.define_metric("val/*", step_metric="training_step")
os.environ["WEAVE_PRINT_CALL_LINK"] = os.getenv(
"WEAVE_PRINT_CALL_LINK", "False"
)
Expand Down