ppd-emit.c: Fix SEGV in 'ppdEmitString()'#850
Merged
zdohnal merged 3 commits intoOpenPrinting:masterfrom Jan 4, 2024
Merged
Conversation
When using testppd.c as a harness, a fuzzer found a way to call ppdPageSize() with NULL return value. This caused a segmentation fault because the size structure, which is used by values[pos], was assigned a NULL value. To avoid this, we need to add a NULL value check for the size structure, free allocated memory, and return NULL. Fixes OpenPrinting#849
zdohnal
requested changes
Jan 2, 2024
Member
|
Note to myself - push it into libppd once merged. |
Member
|
Tests are failing on the similar place as before, so it looks ok to me. |
Member
|
@Drawishe thank you for the fix! |
Member
|
One late note - it would be great if you squashed the commits next time if possible, it gives cleaner git history. |
|
@zdohnal |
Member
|
@jsmeix thanks Johannes, it was really "squash".... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
testppd.cas a harness, a fuzzer found a way to callppdPageSize()with NULL return value.This caused a segmentation fault because the size structure, which is used by
values[pos], was assigned a NULL value.To avoid this, we need to add a NULL value check for the size structure, free allocated memory, and return NULL.
Fixes #849