Use XML Make or Model for 1284DeviceID line if other info is missing#11
Merged
tillkamppeter merged 1 commit intoOpenPrinting:masterfrom Feb 10, 2024
ValdikSS:master
Merged
Use XML Make or Model for 1284DeviceID line if other info is missing#11tillkamppeter merged 1 commit intoOpenPrinting:masterfrom ValdikSS:master
tillkamppeter merged 1 commit intoOpenPrinting:masterfrom
ValdikSS:master
Conversation
Windows 10 and 11 require 1284DeviceID to contain MFG and MDL elements, otherwise the shared printer would silently fail upon adding (or install endlessly, without any error). If the XML file does not have <autodetect> section, use general <make> and <model> data to construct 1284DeviceID.
Member
|
Thank you very much for the fix, I have applied it now, and so Windows compatibility of our generated PPD files should be assured. |
Member
Author
|
@tillkamppeter, please consider pushing the update to Debian 12, with rebuilding of foo2zjs and foomatic-db-compressed-ppds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows 10 and 11 require 1284DeviceID to contain MFG and MDL elements, otherwise the shared printer would silently fail upon adding (or install endlessly, without any error).
If the XML file does not have
<autodetect>section, use general<make>and<model>data to construct 1284DeviceID.Closes #10