ppd-cache.c: Use 0.5mm for delta when comparing sizes#46
Merged
tillkamppeter merged 1 commit intoOpenPrinting:masterfrom Aug 2, 2024
Merged
ppd-cache.c: Use 0.5mm for delta when comparing sizes#46tillkamppeter merged 1 commit intoOpenPrinting:masterfrom
tillkamppeter merged 1 commit intoOpenPrinting:masterfrom
Conversation
@szlt5 found out libppd does not use the same delta as CUPS, which causes filters to use first size from the array, because the similar size according PWG (which recommends max delta 0.5mm) is not matched as useable. Related to OpenPrinting#29, but not fixing the original issue.
tillkamppeter
approved these changes
Aug 2, 2024
|
@tillkamppeter So fast to approve... @zdohnal Thanks, but the fix is incomplete. There is another macro |
Member
Author
|
@szlt5 I'm sorry, I have pushed the additional change now (@tillkamppeter I took the liberty to do it without review, since it is the same fix). |
Member
Author
|
I have the additional change prepared in the branch once I saw @szlt5 comment, but I was too slow :D . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@szlt5 found out libppd does not use the same delta as CUPS, which causes filters to use first size from the array, because the similar size according PWG (which recommends max delta 0.5mm) is not matched as useable.
Related to #29, but not fixing the original issue.
@szlt5 thank you for finding it!