Replace bytes with bytearray for massive speed up#5
Merged
tillkamppeter merged 1 commit intoOpenPrinting:masterfrom Jan 21, 2025
ValdikSS:master
Merged
Replace bytes with bytearray for massive speed up#5tillkamppeter merged 1 commit intoOpenPrinting:masterfrom ValdikSS:master
tillkamppeter merged 1 commit intoOpenPrinting:masterfrom
ValdikSS:master
Conversation
Bytes type is very inefficient for append/concatenation and involves copying the entire data. This one-line fix speeds up foomatic-db compression from ~20 minutes to 10 seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bytes type is very inefficient for append/concatenation and involves copying the entire data.
This one-line fix speeds up foomatic-db compression from ~20 minutes to 10 seconds.