#375 Add checkbox for sharing when adding a printer#376
Merged
zdohnal merged 1 commit intoOpenPrinting:masterfrom Feb 24, 2025
Merged
#375 Add checkbox for sharing when adding a printer#376zdohnal merged 1 commit intoOpenPrinting:masterfrom
zdohnal merged 1 commit intoOpenPrinting:masterfrom
Conversation
In the printer add menu there is no checkbox or any other way to specify whether to use shared access or not when adding a device. The device is set to the default value defined in CUPS after adding. The patch adds a new line to the "Describe Printer" section, containing a checkbox that allows users to specify whether to use shared access or not for the device being added
lazyDesertMan
force-pushed
the
master
branch
from
9b7c044 to
7c9e377
Compare
zdohnal
approved these changes
Feb 24, 2025
Member
zdohnal
left a comment
zdohnal
left a comment
There was a problem hiding this comment.
LGTM! I'm sorry for delay, and thank you for PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the printer add menu there is no checkbox or any other way to specify whether to use shared access or
not when adding a device. The device is set to the default value defined in CUPS after adding.
The patch adds a new line to the "Describe Printer" section, containing a checkbox that allows users to specify whether to use shared access or not for the device being added