Conversation
navi-desu
commented
Mar 28, 2025
Member
Author
|
i'll fix the ci tomorrow i left a trailing whitespace somewhere |
N-R-K
reviewed
Mar 28, 2025
Contributor
N-R-K
left a comment
N-R-K
left a comment
There was a problem hiding this comment.
Just a cursory glance. Haven't looked too deeply since it's a pretty large change.
navi-desu
force-pushed
the
dirfd
branch
2 times, most recently
from
2b27eec to
32635b6
Compare
N-R-K
suggested changes
Mar 30, 2025
navi-desu
force-pushed
the
dirfd
branch
3 times, most recently
from
0c62470 to
b6df440
Compare
Member
Author
|
currently this looks good imo, i'm only unsure about the rc_scripdirfd bits i'll wait a bit to see if anyone has any opinion, and either merge, or ax those commits and think about that later on... |
navi-desu
force-pushed
the
dirfd
branch
2 times, most recently
from
730f15a to
f16be8a
Compare
N-R-K
suggested changes
Apr 9, 2025
Contributor
N-R-K
left a comment
N-R-K
left a comment
There was a problem hiding this comment.
Looks mostly okay, aside from rc_scriptdirfd() and friends.
this allows us to do atomic operations in the runtime directories used by openrc, while at the same time avoiding unnecessary path allocations and reducing syscalls the function "lazy loads" the fds by only opening them once when requested, with O_CLOEXEC set so no cleanup is required
navi-desu
force-pushed
the
dirfd
branch
5 times, most recently
from
0d9d943 to
482dadc
Compare
this also fixes the behaviour of rc_service_scheduled_by, returning a stringlist of service names, instead of the script that is being scheduled.
we would no longer need to create runtime directories during the (conditional) dependency update needed check, so we can remove the checks from there and instead rely on the directory apis
the fd list is only populated with scriptdirs that exist, since some might not be in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gives us atomic operations, removes almost all path string allocations, and reduces the number of syscalls