Fix RCT1 inverted train diagonal transitions #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When i initially ported the 2-across inverted trains i made an error on the "flatBanked22": 8, and "slopes8Banked22" sprite groups, these are only used for diagonal banking transitions and the error was pretty subtle so it slipped through but it would cause the trains to slightly jank up & down when going through specific banking transition pieces. This error was carried over to the RCT1LL 4-across invert trains & face-off trains as they use the exact same sprite mapping as the 2-across trains. I've fixed the error on all affected vehicles.
I did have to use the initial project version of the image tables to do this so the current automatic formatting has been lost until it gets reformatted manually or by the next localization sync.
I also fixed a typo on the face-off cars as their "limitAirTimeBonus" flag typo'd at some point
Before:
After:
RCT2 vehicles for comparison: