Skip to content

Handle unknown models #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnthonyRonning merged 1 commit into from
Jun 10, 2025
Merged

Handle unknown models #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions frontend/src/components/ModelSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ const MODEL_CONFIG: Record<
badge: "Coming Soon",
disabled: true
},
"leon-se/gemma-3-27b-it-fp8-dynamic": {
displayName: "Gemma 3 27B",
badge: "Coming Soon",
disabled: true
},
Comment thread
AnthonyRonning marked this conversation as resolved.
"deepseek-r1-70b": {
displayName: "DeepSeek R1 70B",
badge: "Pro",
Expand Down Expand Up @@ -115,9 +120,10 @@ export function ModelSelector() {

const getDisplayName = (modelId: string, showLock = false) => {
const config = MODEL_CONFIG[modelId];
const elements: React.ReactNode[] = [];

if (config) {
const elements: React.ReactNode[] = [config.displayName];
elements.push(config.displayName);

if (config.badge) {
let badgeClass = "text-[10px] px-1.5 py-0.5 rounded-sm font-medium";
Expand All @@ -140,13 +146,21 @@ export function ModelSelector() {
if (showLock && config.requiresPro && !hasAccessToModel(modelId)) {
elements.push(<Lock key="lock" className="h-3 w-3 opacity-50" />);
}

return <span className="flex items-center gap-1">{elements}</span>;
} else {
// Unknown models: show model ID with "Coming Soon" badge
const model = availableModels.find((m) => m.id === modelId);
elements.push(model?.id || modelId);
elements.push(
<span
key="badge"
className="text-[10px] px-1.5 py-0.5 rounded-sm font-medium bg-gray-500/10 text-gray-600"
>
Coming Soon
</span>
);
}

// Fallback to model ID if not in config
const model = availableModels.find((m) => m.id === modelId);
return model?.id || modelId;
return <span className="flex items-center gap-1">{elements}</span>;
};

// Always show the same format, whether dropdown or not
Expand Down Expand Up @@ -175,8 +189,9 @@ export function ModelSelector() {
.sort((a, b) => {
const aConfig = MODEL_CONFIG[a.id];
const bConfig = MODEL_CONFIG[b.id];
const aDisabled = aConfig?.disabled || false;
const bDisabled = bConfig?.disabled || false;
// Unknown models are treated as disabled
const aDisabled = aConfig?.disabled || !aConfig;
const bDisabled = bConfig?.disabled || !bConfig;
const aRestricted = (aConfig?.requiresPro || false) && !hasAccessToModel(a.id);
const bRestricted = (bConfig?.requiresPro || false) && !hasAccessToModel(b.id);

Expand All @@ -192,7 +207,8 @@ export function ModelSelector() {
})
.map((availableModel) => {
const config = MODEL_CONFIG[availableModel.id];
const isDisabled = config?.disabled || false;
// Unknown models are treated as disabled
const isDisabled = config?.disabled || !config;
const requiresPro = config?.requiresPro || false;
const hasAccess = hasAccessToModel(availableModel.id);
const isRestricted = requiresPro && !hasAccess;
Expand Down
Loading