-
Notifications
You must be signed in to change notification settings - Fork 7
Gemma 3 with image processing #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
7a613a4
Gemma 3 with image processing
AnthonyRonning 3f03260
Disable non-image models when image
AnthonyRonning 54cd114
Refactor chat view
AnthonyRonning 512194f
fix: add type safety to fileToDataURL function
claude[bot] 51ec0d0
Restrict image types for upload
AnthonyRonning d16f041
Update frontend/src/state/LocalStateContextDef.ts
AnthonyRonning fe893e7
fix double mount issue on photo upload
AnthonyRonning 3e7aded
Fix thinking markdown streaming
AnthonyRonning 0b6e7b9
Fix title generation
AnthonyRonning 8695d2b
fix: handle both capture groups in think tag regex pattern
claude[bot] 9926923
fix: improve error handling and model capability detection in useChat…
claude[bot] 8a6c8c5
feat: Add document upload support with OpenSecret SDK
AnthonyRonning 6b960a2
security: add rehype-sanitize to prevent XSS in document preview
claude[bot] a6e278c
Fix document parsing logic and icon
AnthonyRonning 8d072ae
refactor: use shared MODEL_CONFIG for vision capability checks
AnthonyRonning d2304c7
fix: add opacity-50 to Camera icon for visual consistency with Lock icon
AnthonyRonning 7315108
fix: remove type assertion and properly handle multimodal content in …
AnthonyRonning afe785c
fix: prevent memory leaks by properly revoking object URLs for upload…
AnthonyRonning c374f9d
refactor: consolidate MODEL_CONFIG to single source of truth
AnthonyRonning b430f0d
fix: replace unsafe type assertions with proper type guards for messa…
AnthonyRonning 72455fe
fix: allow document-only and image-only submissions without requiring…
AnthonyRonning 6a05537
refactor: remove "Here is a document:" prefix when combining document…
AnthonyRonning 1f15947
fix: enable submit button for document-only and image-only submissions
AnthonyRonning 718d75f
fix: document preview button not showing for document-only messages
AnthonyRonning 8701ed5
fix: improve JSON parsing security in parseDocumentJson
AnthonyRonning 989cc43
feat: add user notifications for image upload failures
AnthonyRonning 0000a32
refactor: use CSS text-overflow instead of manual truncation
AnthonyRonning 2d5e52e
feat: add file size validation and improved upload indicators
AnthonyRonning 25cc022
feat: add ARIA labels for better accessibility
AnthonyRonning 4e315e9
Refactor document parsing logic
AnthonyRonning ef938f6
fix: iOS image upload using canvas fallback when FileReader unavailable
AnthonyRonning 1164b3e
docs: add iOS build troubleshooting guide and update gitignore
AnthonyRonning 3974b03
feat: consolidate image and document upload into single + button with…
claude[bot] 9d5e067
feat: consolidate image and document upload into single + button with…
claude[bot] f90b746
feat: show upload button for all users with Pro upgrade prompts
AnthonyRonning 2e5be49
feat: improve image upload UX with auto-model switching
AnthonyRonning 2d42992
chore: update pre-commit hook to check formatting instead of auto-fix
AnthonyRonning 892aa05
fix: restore chat draft functionality and remove auto-save on model c…
AnthonyRonning 58c444d
Update pricing documentation
AnthonyRonning 9480afa
fix: improve upload dropdown UI consistency for free users
AnthonyRonning cf0c90b
feat: increase document upload limit from 1MB to 5MB and improve uplo…
AnthonyRonning 7d912a3
feat: migrate document upload to new task-based API
AnthonyRonning 17cf5fe
feat: enable markdown (.md) file selection in document upload
claude[bot] 5a88ebf
feat: process text files locally without server upload
AnthonyRonning File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| # iOS Build Troubleshooting | ||
|
|
||
| ## arm64-sim Architecture Error | ||
|
|
||
| ### Problem | ||
| When building for iOS simulator, you may encounter this error: | ||
| ``` | ||
| clang: error: version '-sim' in target triple 'arm64-apple-ios13.0-simulator-sim' is invalid | ||
| ``` | ||
|
|
||
| This happens when the Xcode project file incorrectly lists `arm64-sim` as an architecture, causing a duplicate `-sim` suffix in the target triple. | ||
|
|
||
| ### Solution | ||
|
|
||
| 1. **Edit the Xcode project file** (`frontend/src-tauri/gen/apple/maple.xcodeproj/project.pbxproj`): | ||
|
|
||
| Find and replace all occurrences of: | ||
| ``` | ||
| ARCHS = ( | ||
| arm64, | ||
| "arm64-sim", | ||
| ); | ||
| ``` | ||
|
|
||
| With: | ||
| ``` | ||
| ARCHS = ( | ||
| arm64, | ||
| x86_64, | ||
| ); | ||
| ``` | ||
|
|
||
| 2. **Update VALID_ARCHS**: | ||
|
|
||
| Replace: | ||
| ``` | ||
| VALID_ARCHS = "arm64 arm64-sim"; | ||
|
AnthonyRonning marked this conversation as resolved.
|
||
| ``` | ||
|
|
||
| With: | ||
| ``` | ||
| VALID_ARCHS = "arm64 x86_64"; | ||
| ``` | ||
|
|
||
| 3. **Update EXCLUDED_ARCHS**: | ||
|
|
||
| Replace: | ||
| ``` | ||
| "EXCLUDED_ARCHS[sdk=iphoneos*]" = "arm64-sim x86_64"; | ||
| ``` | ||
|
|
||
| With: | ||
| ``` | ||
| "EXCLUDED_ARCHS[sdk=iphoneos*]" = x86_64; | ||
| ``` | ||
|
AnthonyRonning marked this conversation as resolved.
|
||
|
|
||
| ### Important Notes | ||
|
|
||
| - Keep the `arm64-sim` references in library search paths and output paths - these refer to directory names, not architectures | ||
| - This issue can reoccur if the Xcode project is regenerated | ||
| - Related to Xcode 16.3+ behavior changes with simulator architectures | ||
|
|
||
| ### Prevention | ||
|
|
||
| To prevent this issue from recurring: | ||
|
|
||
| 1. Avoid regenerating the iOS project unless necessary | ||
| 2. If you must regenerate, check the project.pbxproj file for incorrect `arm64-sim` architecture entries | ||
| 3. Consider adding a post-generation script to automatically fix these entries | ||
|
|
||
| ### Reference | ||
|
|
||
| This issue is tracked in [tauri-apps/tauri#12882](https://github.com/tauri-apps/tauri/issues/12882) | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.