Skip to content

Client #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnthonyRonning merged 2 commits into from
Feb 21, 2025
Merged

Client #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0477365
Client id
AnthonyRonning Feb 11, 2025
d0431e7
Update PCRs
AnthonyRonning Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified frontend/bun.lockb
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"format:check": "prettier --check \"src/**/*.{ts,tsx,js,jsx,json,css,md}\""
},
"dependencies": {
"@opensecret/react": "0.3.5",
"@opensecret/react": "0.4.0",
"@radix-ui/react-alert-dialog": "^1.1.1",
"@radix-ui/react-avatar": "^1.1.0",
"@radix-ui/react-dialog": "^1.1.1",
Expand Down
7 changes: 5 additions & 2 deletions frontend/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export default function App() {
return (
<OpenSecretProvider
apiUrl={import.meta.env.VITE_OPEN_SECRET_API_URL}
clientId={import.meta.env.VITE_CLIENT_ID}
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify the environment variable configuration.

The clientId is sourced from VITE_CLIENT_ID environment variable. Ensure this variable is properly configured in:

  1. Local development environment
  2. CI/CD pipeline
  3. Production environment

Run this script to check the environment variable configuration:

🏁 Script executed:

#!/bin/bash
# Description: Check for environment variable configuration files

# Look for environment configuration files
echo "Checking for environment configuration files..."
fd -t f "^\.env" -X cat

Length of output: 338

The previous script’s results indicate that the search pattern didn’t include hidden files, so we couldn’t verify the existence or proper configuration of environment variable files. Please re-run the above script to inspect the hidden .env files. Once confirmed, update the environment variable settings in your local, CI/CD, and production configurations if needed.

🏁 Script executed:

#!/bin/bash
# Description: Check for environment variable configuration files (including hidden files)
echo "Checking for hidden environment configuration files..."
fd -H -t f '^\.env' -X cat

Length of output: 459

Attention: Environment Variable Misconfiguration Detected

The current configuration files inspected do not include a definition for VITE_CLIENT_ID, which is being referenced in the clientId={import.meta.env.VITE_CLIENT_ID} code. Please ensure that the VITE_CLIENT_ID variable is properly defined and propagated across your local development, CI/CD pipeline, and production environment.

  • Confirm that the appropriate environment file (or external configuration mechanism) includes a valid value for VITE_CLIENT_ID.
  • If this variable is intended to be set elsewhere, update the configuration or add necessary documentation to clarify where it is defined.

pcrConfig={{
pcr0Values: [
"ed9109c16f30a470cf0ea2251816789b4ffa510c990118323ce94a2364b9bf05bdb8777959cbac86f5cabc4852e0da71",
Expand All @@ -57,7 +58,8 @@ export default function App() {
"a1398fa2946b6ed4b96a1a992ee668aef3661329690f87d44cad5b646ce33e3b16a55674b1d6d54d115a5520801b97d6",
"878dc4111e94722f3d33b202dc1368916af2eb486e74b3d94c9dfbcb3d981fa652827ea8e951ddfe06d1cefb482e431c",
"4e242871fecc14933c889908a6a7593de574c2655a47ffa163c5fd7ba41d063152ef441bd555ac7f8569eac4fd7cbc8b",
"095d38ba5c9c7ad1cfe5832d3dd8304b020392867aeef84f47e08b4305b867540b0ff5b2eb7d279de410e19ad937896e"
"095d38ba5c9c7ad1cfe5832d3dd8304b020392867aeef84f47e08b4305b867540b0ff5b2eb7d279de410e19ad937896e",
"72c9a1dc207d919196c78f845c0f5fd4b3b3a690e024a3dd599f160be04875fbe52983773909a9f1584105f7d5103538"
],
pcr0DevValues: [
"799600ba64a29e360b1651f4ced6c9ca5323094a45294551327b996062c3f21e6fef651e7e3d97ec8d25be87b9935b4f",
Expand All @@ -68,7 +70,8 @@ export default function App() {
"0042958bde1fdd1bcbd4085ec94456c49e7bc5d2c3368f6f34edd6f339193cb7b53929d299eaf6a220ed5b7691f8618a",
"583ac140e0454dd4766a07c147cb6d90d5430d6bc9c1571da19c781dea4027e1c434273caba584440180ca42c2db84d5",
"4451e47ddb4be8a63492e62bc400e69d924188040805c658334f708e8682d308af3feb16018e98a5589c345d28437a6b",
"5bc5a32791948dc7e315d01ec787307799bb6f70903d14c20dc47f19bb0ef3830eb3b2c5b04b7ae5b04717046b357a14"
"5bc5a32791948dc7e315d01ec787307799bb6f70903d14c20dc47f19bb0ef3830eb3b2c5b04b7ae5b04717046b357a14",
"4243170eeb11d38cf9bbee48b754bccfe97385b4639051efe97cda50086784cd32009dcb89a0fb1098558f22dc55b4e6"
]
}}
>
Expand Down