-
Notifications
You must be signed in to change notification settings - Fork 7
Add fullscreen mode for chat input #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Textarea never actually reaches fullscreen height due to 200px JS cap
The fullscreen UI/UX wiring looks good (logo + prompt hidden, container widened to
max-w-6xl, input boxh-[70vh] max-h-[800px], toggle button, branding, etc.). However, the existing auto-resize effect still enforces a hard200pxmax height on the textarea:So even in fullscreen, the textarea never grows beyond 200px, which defeats the goal of a large 70vh editor.
A minimal fix is to make the auto-resize aware of
isFullscreenand allow a larger cap there, while preserving current behavior elsewhere:This keeps the compact behavior for the non-fullscreen inputs while allowing the fullscreen editor to grow toward the intended 70vh/800px height as the prompt gets longer.
Optional UX note: fullscreen is currently only available in the “new chat” view (
messages.length === 0 && !chatId). If you later want fullscreen while in an active conversation as well, you could reuse this same toggle and state in the bottom input layout to keep the experience consistent.Also applies to: 2470-2487, 2496-2499, 2688-2709
🤖 Prompt for AI Agents