Fix release CI: pin nttld/setup-ndk to v1.5.0#434
Merged
AnthonyRonning merged 1 commit intomasterfrom Feb 25, 2026
Merged
Conversation
Same fix as 56a6791 for android-build.yml. The v1.6.0 release broke NDK extraction, leaving clang binaries missing in the release workflow too. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Setup Android NDK action version in the release workflow is updated from v1 to v1.5.0. This is a straightforward version bump modification with no changes to workflow logic or control flow. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as 56a6791 for
android-build.yml. The v1.6.0 release ofnttld/setup-ndkbroke NDK extraction, leavingclangbinaries missing. This pins the release workflow to v1.5.0 as well.See: nttld/setup-ndk#576
Summary by CodeRabbit