-
Notifications
You must be signed in to change notification settings - Fork 7
Use the canonical Llama model ID #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Dropped backward-compatibility aliases for three old model names
The refactoring from if-else to a lookup table removed three previously-existing aliases:
"ibnzterrell/Meta-Llama-3.3-70B-Instruct-AWQ-INT4"(was →"llama-3.3-70b", which chains to"llama3-3-70b")"qwen3-coder-480b"(was →"kimi-k2-5")"leon-se/gemma-3-27b-it-fp8-dynamic"(was →"gemma4-31b")These aliases exist for backward compatibility with persisted user data. When
getChatByIdloads a chat atLocalStateContext.tsx:241, it callsaliasModelName(parsedChat.model). If a user has an old chat stored with one of these model names, it will now pass through un-aliased. The unrecognized model name then won't match anyMODEL_CONFIGentry inModelSelector.tsx, causing incorrect token limit fallbacks (viagetModelTokenLimitatfrontend/src/components/ModelSelector.tsx:78) and broken display names. Similarly,persistChatatfrontend/src/state/LocalStateContext.tsx:96will re-persist the unrecognized name rather than migrating it.Was this helpful? React with 👍 or 👎 to provide feedback.