Clarification of other places for EnvironmentalConditions

[goretkin]

Currently, there are UNKNOWN levels of different environmental conditions, e.g.

        // Intensity of precipitation is unknown (must not be used in ground
        // truth).
        //
PRECIPITATION_UNKNOWN = 0;

in

open-simulation-interface/osi_environment.proto

Line 82 in f9b1382

// Intensity of precipitation is unknown (must not be used in ground

,

which is not to be used in ground truth. Is there another place in which message EnvironmentalConditions appears outside of the ground truth message?

[jdsika]

This is actually due to the fact that the enums of all messages are structured like that. You are in fact correct that the message is currently not used by SensorData but in theory could be by a "rain sensor". We concluded some time ago that is a rule that there are no "unknown" values in a simulation environment because it provides the "ground truth" -> Gods view on earth :)

The comment (must not be used in ground truth) could be left away in this case. I am in favor of keeping the same enum style everywhere instead of removing the "unknown" value?

[jdsika]

@vkresch let's fix this by improving the comment!