Skip to content

Update OSI submodule to version 3.6.0#50

Closed
ClemensLinnhoff wants to merge 1 commit into
masterfrom
49-update-osi-to-newest-release
Closed

Update OSI submodule to version 3.6.0#50
ClemensLinnhoff wants to merge 1 commit into
masterfrom
49-update-osi-to-newest-release

Conversation

@ClemensLinnhoff
Copy link
Copy Markdown
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Dec 15, 2023

Reference to a related issue in the repository

#49

Add a description

Update OSI submodule to version 3.6.0

Mention a member

@vkresch @jdsika

Check the checklist

  • My code and comments follow the contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-validation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>
@ClemensLinnhoff ClemensLinnhoff linked an issue Dec 15, 2023 that may be closed by this pull request
@vkresch
Copy link
Copy Markdown
Contributor

vkresch commented Dec 18, 2023

Thanks for creating the PR but this needs to be checked with github actions pipeline implemented in #48 before we can merge this. The default rules and protobuf version might also to be updated.

@jdsika
Copy link
Copy Markdown
Contributor

jdsika commented Jan 9, 2024

I think the installation failure on windows in #48 is due to the old OSI. Can't we merge this branch into the other PR?

Update: I have created #54

@jdsika jdsika closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update OSI to newest Release

3 participants