Skip to content

Remove default check for is_set#61

Merged
jdsika merged 19 commits into
masterfrom
51-enable-setting-a-rule-to-define-if-a-field-is-required
May 16, 2024
Merged

Remove default check for is_set#61
jdsika merged 19 commits into
masterfrom
51-enable-setting-a-rule-to-define-if-a-field-is-required

Conversation

@ClemensLinnhoff
Copy link
Copy Markdown
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Feb 1, 2024

Reference to a related issue in the repository

#51
also fixes #52

Add a description

Remove automatically checking for is_set. Now only explicit is_set rules are checked. Also, is_valid does not generate a warning for a rule violation of a subfield. This is somewhat redundant.

Mention a member

@jdsika

Check the checklist

  • My code and comments follow the contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-validation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

…les are checked. Also, is_valid does not generate a warning for a rule violation of a subfield. This is somewhat redundant.

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff linked an issue Feb 1, 2024 that may be closed by this pull request
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
…nterface check. The documentation has been adjusted accordingly

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
…ing for every field with non-valid sub-fields does not make any sense and clutters up the warning output.

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review March 11, 2024 13:01
@ClemensLinnhoff ClemensLinnhoff requested a review from jdsika March 11, 2024 13:01
@ClemensLinnhoff ClemensLinnhoff requested a review from masipp April 4, 2024 05:18
…eld-is-required

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@jdsika jdsika added feature request Proposals which enhance the interface or add additional features. bug Problems in the build system, build scripts, etc or faults in the interface. labels May 16, 2024
Comment thread .github/workflows/ci.yml Outdated
Comment thread README.md Outdated
Comment thread doc/usage.adoc Outdated
Comment thread doc/usage.adoc

[source,yaml]
----
EnvironmentalConditions:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think that we have to explain how to work with these rules?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanation of how to write rules is in "writing-rules.adoc". Here I added some explanation of the rules that are given as errors in the example trace file and removed the rest.

For the future, I would create a new trace file containing more examples of rule violations and then explain them here. But I would do that after the planned major rework of osi-validation.

@jdsika
Copy link
Copy Markdown
Contributor

jdsika commented May 16, 2024

Did you update the osi version?

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff requested a review from jdsika May 16, 2024 09:30
@jdsika jdsika merged commit a1a9c8b into master May 16, 2024
@jdsika jdsika deleted the 51-enable-setting-a-rule-to-define-if-a-field-is-required branch May 16, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Problems in the build system, build scripts, etc or faults in the interface. feature request Proposals which enhance the interface or add additional features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A field removed from the rules is still tested Enable setting a rule to define, if a field is required

2 participants