Skip to content

Make -d/--default_config flag optional and deprecated#32

Draft
Copilot wants to merge 6 commits into
mainfrom
copilot/make-d-flag-optional
Draft

Make -d/--default_config flag optional and deprecated#32
Copilot wants to merge 6 commits into
mainfrom
copilot/make-d-flag-optional

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 23, 2026

Keeps the -d/--default_config flag, keeping it mutually exclusive with -c/--config_path to preserve the original CLI contract. The flag is accepted but has no effect — default config is already used whenever -c is omitted.

Copy link
Copy Markdown
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine tuning help text

Comment thread qc_ositrace/main.py Outdated
"-d",
"--default_config",
action="store_true",
help="Deprecated. Retained for backward compatibility. Default configuration is used whenever -c is omitted.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help="Deprecated. Retained for backward compatibility. Default configuration is used whenever -c is omitted.",
help="Deprecated. Default configuration is used whenever -c is omitted.",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in b65e2b4 — removed "Retained for backward compatibility." from the help string.

Comment thread README.md Outdated
Comment on lines +61 to +62
-d, --default_config Deprecated. Retained for backward compatibility. Default configuration is used whenever -c is
omitted.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-d, --default_config Deprecated. Retained for backward compatibility. Default configuration is used whenever -c is
omitted.
-d, --default_config Deprecated. Default configuration is used whenever -c is omitted.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in b65e2b4.

Comment thread README.md Outdated
Comment on lines +156 to +157
-d, --default_config Deprecated. Retained for backward compatibility. Default configuration is used whenever -c is
omitted.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-d, --default_config Deprecated. Retained for backward compatibility. Default configuration is used whenever -c is
omitted.
-d, --default_config Deprecated. Default configuration is used whenever -c is omitted.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in b65e2b4.

Copilot finished work on behalf of pmai April 23, 2026 19:41
Copilot AI requested a review from pmai April 23, 2026 19:41
@pmai pmai changed the title Retain -d/--default_config flag as deprecated no-op for backward compatibility Make -d/--default_config flag optional and deprecated Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants