Skip to content

fix issue : Undo of remove element doesn’t put it back in the same po… #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MagueresMathieu wants to merge 6 commits into
base: devStage
Choose a base branch
from
Open

fix issue : Undo of remove element doesn’t put it back in the same po… #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8550b54
fix issue : Undo of remove element doesn’t put it back in the same po…
Apr 21, 2026
4e82ec8
update devStage_fixIssueUndo187
Apr 23, 2026
d425f9f
update fix issue : Undo of remove element doesn’t put it back in the …
Apr 28, 2026
f1a4ef9
Merge 4e82ec8a0a53bdc6a6c79189f207fd69e4f0d5c6
Apr 28, 2026
40f8dc2
update fix issue : Undo of remove element doesn’t put it back in the …
Apr 28, 2026
4134e51
update fix issue : Undo of remove element doesn’t put it back in the …
Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Pyramid-Bloc/PyramidAbstractBorderCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ PyramidAbstractBorderCommand >> borderBuilderOf: aBlElement [
^ builder
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidAbstractBorderCommand >> setValueFor: aBlElement with: anArgument [

| builder |
Expand Down
2 changes: 1 addition & 1 deletion src/Pyramid-Bloc/PyramidAbstractChangeDrawOrderCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ PyramidAbstractChangeDrawOrderCommand >> canBeUsedFor: anObject [
^ (super canBeUsedFor: anObject) and: [ anObject hasParent]
]

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidAbstractChangeDrawOrderCommand >> getValueFor: aBlElement [
"return current index for testing."

Expand Down
18 changes: 15 additions & 3 deletions src/Pyramid-Bloc/PyramidAddChildCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,26 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc'
}

{ #category : #'as yet unclassified' }
{ #category : #history }
PyramidAddChildCommand >> commandInverse [

^ PyramidRemoveChildCommand new
]

{ #category : #'as yet unclassified' }
{ #category : #private }
PyramidAddChildCommand >> savedIndexFor: aChild in: aParent [

| index |
index := aChild userData at: #removedAtIndex ifAbsent: [ 0 ].
(index = 0 or: [ index > aParent children size ])
ifTrue: [ ^ aParent children size + 1 ]
ifFalse: [ ^ index ]
]

{ #category : #setter }
PyramidAddChildCommand >> setValueFor: aBlElement with: aChildToAdd [

aBlElement addChild: aChildToAdd
aBlElement
addChild: aChildToAdd
at: (self savedIndexFor: aChildToAdd in: aBlElement)
]
6 changes: 3 additions & 3 deletions src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc'
}

{ #category : #'as yet unclassified' }
{ #category : #history }
PyramidAddChildrenCommand >> commandInverse [

^ PyramidRemoveChildrenCommand new
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidAddChildrenCommand >> setValueFor: aBlElement with: aChildrenToAdd [

aBlElement addChildren: aChildrenToAdd
aBlElement addChildren: aChildrenToAdd
]
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBackgroundImageCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ PyramidBackgroundImageCommand >> canBeUsedFor: anObject [
anObject background isKindOf: BlImageBackground ]
]

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundImageCommand >> getValueFor: aBlElement [

^ aBlElement background image
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundImageCommand >> setValueFor: aBlElement with: anArgument [

aBlElement background: (BlBackground image: anArgument)
Expand Down
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBackgroundOpacityCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-visuals'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundOpacityCommand >> getValueFor: aBlElement [

^ aBlElement background opacity
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundOpacityCommand >> setValueFor: aBlElement with: anArgument [

| background |
Expand Down
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBackgroundPaintColorCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ PyramidBackgroundPaintColorCommand >> canBeUsedFor: anObject [
anObject background paint isKindOf: BlColorPaint ] ]
]

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundPaintColorCommand >> getValueFor: aBlElement [

^ aBlElement background paint color
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundPaintColorCommand >> setValueFor: aBlElement with: anArgument [

aBlElement background: (BlBackground paint: anArgument asBlPaint)
Expand Down
6 changes: 3 additions & 3 deletions src/Pyramid-Bloc/PyramidBackgroundPaintCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@ PyramidBackgroundPaintCommand >> canBeUsedFor: anObject [
anObject background isKindOf: BlPaintBackground ]
]

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundPaintCommand >> getGroupedValueFor: aBlElement [

^ aBlElement background paint class
]

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundPaintCommand >> getValueFor: aBlElement [

^ aBlElement background paint
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundPaintCommand >> setValueFor: aBlElement with: anArgument [

aBlElement background: (BlBackground paint: anArgument value)
Expand Down
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBackgroundPaintLinearEndCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-visuals'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundPaintLinearEndCommand >> getValueFor: aBlElement [

^ aBlElement background paint end
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundPaintLinearEndCommand >> setValueFor: aBlElement with: anArgument [

aBlElement background paint end: anArgument
Expand Down
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBackgroundPaintLinearStartCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-visuals'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundPaintLinearStartCommand >> getValueFor: aBlElement [

^ aBlElement background paint start
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundPaintLinearStartCommand >> setValueFor: aBlElement with: anArgument [

aBlElement background paint start: anArgument
Expand Down
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBackgroundPaintRadialInnerCenterCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-visuals'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundPaintRadialInnerCenterCommand >> getValueFor: aBlElement [

^ aBlElement background paint innerCenter
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundPaintRadialInnerCenterCommand >> setValueFor: aBlElement with: anArgument [

aBlElement background paint innerCenter: anArgument
Expand Down
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBackgroundPaintRadialInnerRadiusCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-visuals'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundPaintRadialInnerRadiusCommand >> getValueFor: aBlElement [

^ aBlElement background paint innerRadius
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundPaintRadialInnerRadiusCommand >> setValueFor: aBlElement with: anArgument [

aBlElement background paint innerRadius: anArgument
Expand Down
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBackgroundPaintRadialOuterCenterCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-visuals'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundPaintRadialOuterCenterCommand >> getValueFor: aBlElement [

^ aBlElement background paint outerCenter
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundPaintRadialOuterCenterCommand >> setValueFor: aBlElement with: anArgument [

aBlElement background paint outerCenter: anArgument
Expand Down
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBackgroundPaintRadialOuterRadiusCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-visuals'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundPaintRadialOuterRadiusCommand >> getValueFor: aBlElement [

^ aBlElement background paint outerRadius
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundPaintRadialOuterRadiusCommand >> setValueFor: aBlElement with: anArgument [

aBlElement background paint outerRadius: anArgument
Expand Down
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBackgroundPaintStopsCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ PyramidBackgroundPaintStopsCommand >> canBeUsedFor: anObject [
anObject background paint isKindOf: BlGradientPaint ] ]
]

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundPaintStopsCommand >> getValueFor: aBlElement [
"We ensure that we are working with a copy of the associations."

^ aBlElement background paint stops collect: [ :asso |
asso key copy -> asso value copy ]
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundPaintStopsCommand >> setValueFor: aBlElement with: anArgument [
"We ensure that we are working with a copy of the associations."

Expand Down
6 changes: 3 additions & 3 deletions src/Pyramid-Bloc/PyramidBackgroundTypeCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,19 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-visuals'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundTypeCommand >> getGroupedValueFor: aBlElement [

^ aBlElement background class
]

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBackgroundTypeCommand >> getValueFor: aBlElement [

^ aBlElement background
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBackgroundTypeCommand >> setValueFor: aBlElement with: anArgument [
"Must be a blockClosure to ensure no background are created."

Expand Down
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBasicExactHorizontalConstraintsBlocCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ PyramidBasicExactHorizontalConstraintsBlocCommand >> canBeUsedFor: anObject [
anObject constraints horizontal resizer isExact ]
]

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBasicExactHorizontalConstraintsBlocCommand >> getValueFor: anObject [

^ anObject constraints horizontal resizer size
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBasicExactHorizontalConstraintsBlocCommand >> setValueFor: anObject with: anArgument [

^ anObject constraintsDo: [ :c | c horizontal exact: anArgument ]
Expand Down
4 changes: 2 additions & 2 deletions src/Pyramid-Bloc/PyramidBasicExactVerticalConstraintsBlocCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ PyramidBasicExactVerticalConstraintsBlocCommand >> canBeUsedFor: anObject [
anObject constraints vertical resizer isExact ]
]

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBasicExactVerticalConstraintsBlocCommand >> getValueFor: anObject [

^ anObject constraints vertical resizer size
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBasicExactVerticalConstraintsBlocCommand >> setValueFor: anObject with: anArgument [

^ anObject constraintsDo: [ :c | c vertical exact: anArgument ]
Expand Down
6 changes: 3 additions & 3 deletions src/Pyramid-Bloc/PyramidBasicHorizontalConstraintsBlocCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-layout'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBasicHorizontalConstraintsBlocCommand >> getValueFor: anObject [

^ anObject constraints horizontal
]

{ #category : #'as yet unclassified' }
{ #category : #private }
PyramidBasicHorizontalConstraintsBlocCommand >> saveStatesOf: aCollection withCommand: aCommand withArguments: anArguments [

| mementos |
Expand All @@ -26,7 +26,7 @@ PyramidBasicHorizontalConstraintsBlocCommand >> saveStatesOf: aCollection withCo
yourself
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBasicHorizontalConstraintsBlocCommand >> setValueFor: anObject with: anArgument [

anArgument isSymbol
Expand Down
6 changes: 3 additions & 3 deletions src/Pyramid-Bloc/PyramidBasicVerticalConstraintsBlocCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-layout'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBasicVerticalConstraintsBlocCommand >> getValueFor: anObject [

^ anObject constraints vertical
]

{ #category : #'as yet unclassified' }
{ #category : #private }
PyramidBasicVerticalConstraintsBlocCommand >> saveStatesOf: aCollection withCommand: aCommand withArguments: anArguments [

| mementos |
Expand All @@ -27,7 +27,7 @@ PyramidBasicVerticalConstraintsBlocCommand >> saveStatesOf: aCollection withComm
yourself
]

{ #category : #'as yet unclassified' }
{ #category : #setter }
PyramidBasicVerticalConstraintsBlocCommand >> setValueFor: anObject with: anArgument [

anArgument isSymbol
Expand Down
2 changes: 1 addition & 1 deletion src/Pyramid-Bloc/PyramidBorderDashArrayCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-visuals'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBorderDashArrayCommand >> getValueFor: aBlElement [

^ aBlElement border style dashArray
Expand Down
2 changes: 1 addition & 1 deletion src/Pyramid-Bloc/PyramidBorderDashOffsetCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ PyramidBorderDashOffsetCommand >> canBeUsedFor: anObject [
anObject border style dashArray isNotEmpty ]
]

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBorderDashOffsetCommand >> getValueFor: aBlElement [

^ aBlElement border style dashOffset
Expand Down
2 changes: 1 addition & 1 deletion src/Pyramid-Bloc/PyramidBorderLineCapCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-visuals'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBorderLineCapCommand >> getValueFor: aBlElement [

^ aBlElement border style lineCap
Expand Down
2 changes: 1 addition & 1 deletion src/Pyramid-Bloc/PyramidBorderLineJoinCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Class {
#category : #'Pyramid-Bloc-plugin-bloc-visuals'
}

{ #category : #'as yet unclassified' }
{ #category : #getter }
PyramidBorderLineJoinCommand >> getValueFor: aBlElement [

^ aBlElement border style lineJoin
Expand Down
Loading
Loading