Skip to content

81 2 fbc namespace#86

Merged
stellaprins merged 7 commits intodevelopmentfrom
81-2-fbc-namespace
Nov 27, 2024
Merged

81 2 fbc namespace#86
stellaprins merged 7 commits intodevelopmentfrom
81-2-fbc-namespace

Conversation

@stellaprins
Copy link
Collaborator

@stellaprins stellaprins commented Nov 20, 2024 •
edited
Loading

  • Adds missing fbc namespaces (flux balance models) to temp SED-ML files used to create omex files
  • Created omex files (using temporary SED-ML files) are now removed before the scripts end

@stellaprins stellaprins marked this pull request as ready for review November 20, 2024 13:39
@stellaprins stellaprins requested a review from robertvi November 20, 2024 13:39
This was referenced Nov 20, 2024
Closed
Merged
@stellaprins stellaprins self-assigned this Nov 21, 2024
robertvi
robertvi requested changes Nov 25, 2024
View reviewed changes
@stellaprins
first check whether m == None before getting m.span() and improve cla…
d147052 
…rity of add_xmlns_fbc_attribute documentation
robertvi
robertvi requested changes Nov 26, 2024
View reviewed changes
@stellaprins
Copy link
Collaborator Author

stellaprins commented Nov 27, 2024

Thanks @robertvi! I've made your suggested changes.

@stellaprins stellaprins merged commit 5ee58ea into development Nov 27, 2024
@stellaprins stellaprins deleted the 81-2-fbc-namespace branch November 27, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertvi robertvi robertvi approved these changes

Assignees

@stellaprins stellaprins

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stellaprins @robertvi