Conversation
…ing. And Brush up template code for verify JWS token for authentication.
| ```txt | ||
| C:\root\programs\C#\Frameworks\Infrastructure\Public\Dll | ||
| ``` | ||
| 「root」フォルダを、C ドライブ直下にコピーしてください。そうでない場合は、Windows のファイルパスの最大文字長を超え、ビルドに失敗することがあります。 |
There was a problem hiding this comment.
- 「そうでない場合は」→「C ドライブ直下以外にコピーすると」
- 「Windows のファイルパスの最大文字長を超え」→「Windows のファイルパスの最大文字長の制限により」
Enhanced comments about Web API for testing.
|
|
||
| ### Obtaining data provider, Exporting prodedures, Attaching to license | ||
| Obtain and export the data provider, which Open Touryo supports, on your own. | ||
| ### [How to create NuGet packages](https://github.com/OpenTouryoProject/OpenTouryo/wiki/HowToCreateOpenTouryoNuGetPackages) |
There was a problem hiding this comment.
見出しにはリンクを張らないでください。
### How to create Open Touryo NuGet packages
For the method of creating Open Touryo NuGet packages, see [this article](https://github.com/OpenTouryoProject/OpenTouryo/wiki/HowToCreateOpenTouryoNuGetPackages).日本語版も同様に修正してください。
| You can confirm the structure of Open Touryo and the specification of each feature. | ||
| - [Tutorial](https://github.com/OpenTouryoProject/OpenTouryoDocuments/tree/master/documents/2_Tutorial) | ||
| You can see the *first step guide* of Open Touryo. | ||
| ## Other end matter |
There was a problem hiding this comment.
"end matter" は「後付け」という意味ですが、日本語版だと「その他」となっており、意味が違うと思います。
「その他特記事項」という意味なら、"Other items of note" だと思います。
There was a problem hiding this comment.
ココを参考にしましたが、
http://www.nakanihon.co.jp/gijyutsu/Shimada/bunsyo/index.htm
どちらにしましょうか。
- その他の項目, Other end matter
- その他特記事項, Other items of note
There was a problem hiding this comment.
いろいろ調べてみても、"end matter" は「後付け」と出てきます。「後付け」は、「本文の後に続く文章」という意味なので、内容的に「特記事項」のほうが正しいと思います。
| Obtain and export the data provider, which Open Touryo supports, on your own. | ||
| ### [How to create NuGet packages](https://github.com/OpenTouryoProject/OpenTouryo/wiki/HowToCreateOpenTouryoNuGetPackages) | ||
|
|
||
| ### Obtaining libraries, Exporting control prodedures, Attaching to license |
There was a problem hiding this comment.
文章の途中で大文字を使うのは、文法上正しくありません。
There was a problem hiding this comment.
@yusukemaegawa
そこは、元々のトコロですが、修正しました。
NuGetはイイと思いますが、Package Managerもですか？
|
|
||
| ### Obtaining libraries, Exporting control prodedures, Attaching to license | ||
| - Since libraries that can be obtaining from Package Manager do not need to be bundled, they can be excluded from export control. | ||
| - For libraries that are bundled and exported, it is necessary to the exporting control procedure and attaching to license. |
There was a problem hiding this comment.
The libraries that can be obtained from package manager, that is NuGet or npm, are not bundled in Open Touryo. So, you don't have to export the libraries.
You have to obtain and export the other libraries, that is the libraries that can not be obtained from package manager, on your own. And you have to attach the libraries to license.
ライセンスに何を添付しなければならないのかがわからないので、最後の一文はあまり自信がありません。
There was a problem hiding this comment.
@yusukemaegawa
最後の一文ですが、同梱時なので、「（Open棟梁の）ライセンスに（使用するライブラリの）ライセンスを添付する。」だと思います。
There was a problem hiding this comment.
であれば、先ほどの文章を、「（Open棟梁の）ライセンスに（使用するライブラリの）ライセンスを添付する。」の意味になるように修正して、文章全体を修正ください。
| - Since libraries that can be obtaining from Package Manager do not need to be bundled, they can be excluded from export control. | ||
| - For libraries that are bundled and exported, it is necessary to the exporting control procedure and attaching to license. | ||
| - The libraries that can be obtained from package manager, that is NuGet or npm, are not bundled in Open Touryo. So, you don't have to export the libraries. | ||
| - If necessary, you have to obtain and export the other libraries, that is the libraries that can not be obtained from package manager, on your own. In this case, you have to attach the license of libraries to be used to the license of Open Touryo. |
There was a problem hiding this comment.
attach the license of libraries → attach the license of the libraries
ghost
merged commit 2 participants
Release of 02-30 version (within 1 October 2018)
memo of test cases.
Obtain diff in order to confirm the added / changed function, and add test cases as following.