Skip to content

Use UTF8 encoding and simplify godot string conversion#249

Merged
Hop311 merged 1 commit intomasterfrom
utf8-fix
Aug 2, 2024
Merged

Use UTF8 encoding and simplify godot string conversion#249
Hop311 merged 1 commit intomasterfrom
utf8-fix

Conversation

@Hop311
Copy link
Copy Markdown
Contributor

@Hop311 Hop311 commented Jul 31, 2024

Fixes #180: Province names do not convert non-ascii characters to Unicode

@Hop311 Hop311 added the bug label Jul 31, 2024
@Hop311 Hop311 force-pushed the utf8-fix branch 2 times, most recently from 6b8795e to 0419bd6 Compare August 2, 2024 18:23
Comment thread extension/src/openvic-extension/classes/GUIOverlappingElementsBox.cpp Outdated
Comment thread extension/src/openvic-extension/singletons/MenuSingleton.cpp Outdated
wvpm
wvpm previously approved these changes Aug 2, 2024
Fixes #180: Province names do not convert non-ascii characters to Unicode
Copy link
Copy Markdown
Member

@Spartan322 Spartan322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Linux, LGTM

@Hop311 Hop311 merged commit fde15e5 into master Aug 2, 2024
@Hop311 Hop311 deleted the utf8-fix branch August 2, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Province names do not convert non-ascii characters to Unicode

3 participants