This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Fixed the hang issue with each EOS frame.#408
Merged
Conversation
When the application send fake frames (such as with EOS flag), the encoder should make each frame go through the whole encoding kernel stages (from ResourceCoordination to Packetization), otherwise EbH265GetPacket() would be blocked in waiting for the buffer posted by Packetization. Signed-off-by: Austin Hu <austin.hu@intel.com>
Austin-Hu
requested review from
hassount,
intelmark,
lijing0010 and
tianjunwork
and removed request for
tianjunwork
Contributor
Please add it to the main body of the pr in the form of |
Contributor
Author
Yes, I forgot that... |
Contributor
|
You can edit it using the 3 dots on the top right |
Contributor
Author
Done, thanks! :) |
Contributor
|
https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords It needs to be in a certain format for the auto closing |
tianjunwork
reviewed
Nov 1, 2019
Signed-off-by: Austin Hu <austin.hu@intel.com>
intelmark
approved these changes
Nov 6, 2019
tianjunwork
approved these changes
Nov 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the application send fake frames (such as with EOS flag), the
encoder should make each frame go through the whole encoding kernel
stages (from ResourceCoordination to Packetization), otherwise
EbH265GetPacket() would be blocked in waiting for the buffer posted
by Packetization.
Signed-off-by: Austin Hu austin.hu@intel.com
Fixes #367 .