Revert "(PE-36861) Add a needrestart conf file for debian packages"#12
Merged
bastelfreak merged 1 commit intomainfrom Jul 8, 2025
Merged
Revert "(PE-36861) Add a needrestart conf file for debian packages"#12bastelfreak merged 1 commit intomainfrom
bastelfreak merged 1 commit intomainfrom
Conversation
Contributor
Author
|
I don't know a lot about the packaging. Do I need to configure something to ensure the config files are removed on package upgrades? Or will that happen automatically because the files are missing in the latest package? |
ekohl
previously approved these changes
May 7, 2025
This reverts commit e43660e. e43660e added a denylist for needrestart to ignore openvoxdb/openvoxserver. Both services write files into /tmp/, which triggered service restarts, that were not required. Since puppetlabs/ezbake@bf1a75d, both services use the PrivateTmp feature from systemd, that makes the denylist obsolete. This now ensures that needsrestart will restart openvoxdb/openvoxserver on Java updates. That will fix puppetlabs/puppetserver#2900.
bastelfreak
added a commit
to bastelfreak/ezbake
that referenced
this pull request
Jan 2, 2026
This reverts commit e43660e. e43660e added a denylist for needrestart to ignore openvoxdb/openvoxserver. Both services write files into /tmp/, which triggered service restarts, that were not required. Since puppetlabs/ezbake@bf1a75d, both services use the PrivateTmp feature from systemd, that makes the denylist obsolete. This now ensures that needsrestart will restart openvoxdb/openvoxserver on Java updates. That will fix puppetlabs/puppetserver#2900. (cherry picked from commit 2ff6317) --- This is cherry-picked from OpenVoxProject#61 and was originally added in OpenVoxProject#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e43660e.
e43660e added a denylist for needrestart to ignore openvoxdb/openvoxserver. Both services write files into /tmp/, which triggered service restarts, that were not required.
Since
puppetlabs/ezbake@bf1a75d, both services use the PrivateTmp feature from systemd, that makes the denylist obsolete.
This now ensures that needsrestart will restart openvoxdb/openvoxserver on Java updates. That will fix
puppetlabs/puppetserver#2900.
Please add all notable changes to the "Unreleased" section of the CHANGELOG.