Drop service wrappers by ekohl · Pull Request #5 · OpenVoxProject/ezbake

ekohl · 2025-02-20T18:39:17Z

These service wrappers only replicate the default systemd behavior. Running it directly simplifies it greatly.

It's marked as a draft because it's only received very minimal testing from my side. It may be wise to first merge #2 and #4.

ekohl

If we go this route, we may also want to do the same for Debian. There we have some complication that there's also sysvinit. I wouldn't mind dropping that support and going systemd-only, but that could be a larger discussion.

The thought process behind this is that the puppetserver script has IMHO too many complexities and I'd like to trim it down.

resources/puppetlabs/lein-ezbake/template/global/ext/redhat/ezbake.service.erb

bastelfreak · 2025-02-20T19:30:09Z

If we go this route, we may also want to do the same for Debian. There we have some complication that there's also sysvinit.

Yes please. I don't see why we should support sysv.

ekohl · 2025-02-20T20:59:36Z

#8 takes a step in the sysvinit removal direction by at least making sure every platform expects systemd to be present.

ekohl · 2025-02-21T15:48:23Z

I've updated it to include #8, a commit to remove sysvinit on Debian and then modified the service wrapper removal to also cover Debian. Then the cli tools become useless, so they're dropped. This also removes the need to manage the rundir, which help a lot to remove things.

I'm unsure about the foreground cli app.

resources/puppetlabs/lein-ezbake/template/global/ext/debian/ezbake.service.erb

ekohl · 2025-05-23T09:51:53Z

Includes #14 now.

rwaffen · 2025-05-23T12:19:10Z

closes: OpenVoxProject/planning#69

These service wrappers only replicate the default systemd behavior. Running it directly simplifies it greatly because it also drops the need to manage the rundir, which systemd will now take care of for us.

This fixes a regression introduced in #5 / b2de7c7 openvox-server has some ERB templates: https://github.com/OpenVoxProject/openvox-server/tree/main/resources/ext/cli and since above change, they aren't rendered anymore. The templates are still required and builds fail.

This fixes a regression introduced in OpenVoxProject#5 / b2de7c7 openvox-server has some ERB templates: https://github.com/OpenVoxProject/openvox-server/tree/main/resources/ext/cli and since above change, they aren't rendered anymore. The templates are still required and builds fail.

The `/usr` directory contains only two files: ``` /usr /usr/lib /usr/lib/tmpfiles.d /usr/lib/tmpfiles.d/puppetserver.conf /usr/share /usr/share/doc /usr/share/doc/openvox-server /usr/share/doc/openvox-server/changelog.gz ``` Since OpenVoxProject#5, we don't package /usr/lib/tmpfiles.d/puppetserver.conf anymore. And the changelog.gz is autogenerated by fpm afterwards. That means that in our packaging directory, there is no `/usr`. If we force fpm to package it, it will raise an error. This change was tested in https://github.com/OpenVoxProject/openvox-server

bastelfreak · 2025-07-19T21:07:37Z

This introduced a regression. The systemd units now have:

ExecStart="$JAVA_BIN" $JAVA_ARGS

Turns out: Variable interpolation isn't support for the first arg of ExecStart. the unit will fail with:

/usr/lib/systemd/system/puppetserver.service:38: Executable "$JAVA_BIN" not found in path "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin"

It doesn't matter if the variable is in quotes or not. from #systemd on IRC:

2025-07-19 22:44:00     bastelfreak     hey. Can someone tell me what I can use as first parameter for ExecStart= in a unit? I'm trying to use a variable that I got from EnvironmentFile=..., e.g. ExecStart=$JAVA_BIN $JAVA_ARGS and that fails with: Executable "$JAVA_BIN" not found in path
2025-07-19 22:44:47     bastelfreak     If I update it to ExecStart=/usr/bin/java $JAVA_ARGS it works. Can I only use variables for parameters, but not the actual thing I'm starting?
2025-07-19 22:45:46     bastelfreak     I can source the provided environmentfile and echo $JAVA_BIN, so there doesn't seem to be a typo in the file
2025-07-19 22:47:11     bastelfreak     https://gist.github.com/bastelfreak/3dd2abd803dee92cd0b58a1efd1010ee unit file + environment file
2025-07-19 22:52:42     gdamjan bastelfreak: it needs to be a full path
2025-07-19 22:54:33     bastelfreak     derp

I will fix this in #2