Bump cairo version to 0.15#378
Conversation
|
@ericglau any idea why tests are still failing after I updated the 0.14.0 version in all the test files? |
|
@ericnordelo You may need to regenerate snapshots using the
|
|
For completeness, I would normally suggest to add a changelog entry in https://github.com/OpenZeppelin/contracts-wizard/blob/master/packages/core-cairo/CHANGELOG.md and bump the version in https://github.com/OpenZeppelin/contracts-wizard/blob/master/packages/core-cairo/package.json, so we can make a new release of the |
ericglau
left a comment
There was a problem hiding this comment.
LGTM, thanks. I added an Unreleased section in the changelog with this change, so we don't lose track of it for the next npm package release.
|
There is the following error in the Scarb setup step in https://github.com/OpenZeppelin/contracts-wizard/actions/runs/10359200513/job/28675084025?pr=378: |
…ntracts-wizard into feat/update-cairo-to-0.15
This seems to be a warning labeled in the wrong way, that step passes, it looks like the workflow is failing because the compilation takes too much time? |
|
It fails in the |
It seems to failed but it passes, the Error is a warning, notice that the setup-scarb step runs successfully |
|
Oh I see what you mean. In this previous successful build on If I run a |
|
Eric, I ran the test locally and they pass (after 20 minutes). I have removed the workflow at least temporarily to get the PR merged, later we can figure out what to do about it. |
No description provided.